Review main Merged

92896[FEATURE] Add pagination_type setting for indexed_search

Eric Harrer CR +2 V +2 Normal +212 −10 updated 02/24/26, 07:31

Commit message

Add a TypoScript setting pagination_type to switch between
SimplePagination and SlidingWindowPagination for indexed_search.

Keeps "simple" as default to preserve existing behavior.

Integrators can switch to slidingWindow to make page_links
effective for limiting shown page links.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1420

  1. Eric Harrer uploaded patch set 1 02/19/26, 13:22

  2. core-ci voted on patch set 1 V +1 02/19/26, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96246

  3. Garvin Hicking commented on patch set 1 02/19/26, 19:38

    Is there a reason you used a full implementation here instead of the PSR 14 event? I have not investigated,but it's probably to prevent initial pagination that is then changed later on, yes? Apart from that this looks quite promising. Thanks!

    labels.xlf:30

    For new strings in v14 we try to use snake_case - can you adjust this?
  4. Eric Harrer commented on patch set 1 02/20/26, 13:27

    Reply

    The current approach applies `paginationType` directly at pagination construction as baseline core behavior. This is why a core listener is not used as the default implementation: with the existing `ModifySearchResultSetsEvent`, a listener can only act after result sets are built, so pagination changes happen as post-build replacement. I could also implement that event-based replacement only for `paginationType != simple`. Would you prefer to keep the current direct implementation, or switch to the conditional event-based override?
  5. Eric Harrer uploaded patch set 2 V +1 02/20/26, 13:30

  6. Eric Harrer commented on patch set 2 02/20/26, 13:31

    labels.xlf:30 Reply

    Done
  7. core-ci voted on patch set 2 V -1 02/20/26, 13:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96353

  8. Eric Harrer uploaded patch set 3 V -1 02/20/26, 15:04

  9. Eric Harrer uploaded patch set 4 02/20/26, 15:13

  10. Eric Harrer commented on patch set 4 02/20/26, 15:15

    labels.xlf:30 Reply

    In order to use the `labels.xlf` key pattern for `label` and `description`, the change also had to be made for the setting. In this context, it seemed illogical to deviate from the Typoscript context, so I changed it there as well. Lower camel case was therefore replaced by lower snake case in all non-PHP contexts.
  11. Eric Harrer updated the commit message in patch set 5 02/20/26, 15:19

  12. core-ci voted on patch set 4 V +1 02/20/26, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96369

  13. core-ci voted on patch set 5 V +1 02/20/26, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96370

  14. core-ci voted on patch set 3 V +1 02/20/26, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96367

  15. Garvin Hicking commented on patch set 5 CR +1 V +1 02/20/26, 15:48

    Reply

    Let's keep it as is, thanks!
  16. Garvin Hicking uploaded patch set 6 CR +1 V +1 02/23/26, 20:05

  17. core-ci voted on patch set 6 V +1 02/23/26, 20:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96614

  18. Garvin Hicking voted on patch set 6 CR +1 V +1 02/23/26, 20:25

  19. Georg Ringer voted on patch set 6 CR +2 V +2 02/24/26, 07:31

  20. Georg Ringer merged patch set 7 02/24/26, 07:31