92896[FEATURE] Add pagination_type setting for indexed_search
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Garvin Hicking +1
-
Verified V +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-105084-AddSettingToConfigureIndexedSearchPagination.rstnew+42 −0
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+40 −8
- typo3/sysext/indexed_search/Classes/Type/PaginationType.phpnew+27 −0
- typo3/sysext/indexed_search/Configuration/Sets/IndexedSearch/labels.xlf3+12 −0
- typo3/sysext/indexed_search/Configuration/Sets/IndexedSearch/settings.definitions.yaml+11 −0
- typo3/sysext/indexed_search/Configuration/TypoScript/constants.typoscript+4 −0
- typo3/sysext/indexed_search/Configuration/TypoScript/setup.typoscript+2 −1
- typo3/sysext/indexed_search/Documentation/Configuration/TypoScript/Index.rst+21 −1
- typo3/sysext/indexed_search/Tests/Functional/Controller/SearchControllerTest.php+53 −0
Review log 1420
-
Eric Harrer uploaded patch set 1 02/19/26, 13:22
-
core-ci voted on patch set 1 V +1 02/19/26, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96246
-
Garvin Hicking commented on patch set 1 02/19/26, 19:38
Is there a reason you used a full implementation here instead of the PSR 14 event? I have not investigated,but it's probably to prevent initial pagination that is then changed later on, yes? Apart from that this looks quite promising. Thanks!labels.xlf:30For new strings in v14 we try to use snake_case - can you adjust this? -
Eric Harrer commented on patch set 1 02/20/26, 13:27
Reply
The current approach applies `paginationType` directly at pagination construction as baseline core behavior. This is why a core listener is not used as the default implementation: with the existing `ModifySearchResultSetsEvent`, a listener can only act after result sets are built, so pagination changes happen as post-build replacement. I could also implement that event-based replacement only for `paginationType != simple`. Would you prefer to keep the current direct implementation, or switch to the conditional event-based override? -
Eric Harrer uploaded patch set 2
V +102/20/26, 13:30 -
Eric Harrer commented on patch set 2 02/20/26, 13:31
labels.xlf:30ReplyDone -
core-ci voted on patch set 2 V -1 02/20/26, 13:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96353
-
Eric Harrer uploaded patch set 3
V -102/20/26, 15:04 -
Eric Harrer uploaded patch set 4 02/20/26, 15:13
-
Eric Harrer commented on patch set 4 02/20/26, 15:15
labels.xlf:30ReplyIn order to use the `labels.xlf` key pattern for `label` and `description`, the change also had to be made for the setting. In this context, it seemed illogical to deviate from the Typoscript context, so I changed it there as well. Lower camel case was therefore replaced by lower snake case in all non-PHP contexts. -
Eric Harrer updated the commit message in patch set 5 02/20/26, 15:19
-
core-ci voted on patch set 4 V +1 02/20/26, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96369
-
core-ci voted on patch set 5 V +1 02/20/26, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96370
-
core-ci voted on patch set 3 V +1 02/20/26, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96367
-
Garvin Hicking commented on patch set 5 CR +1 V +1 02/20/26, 15:48
Reply
Let's keep it as is, thanks! -
Garvin Hicking uploaded patch set 6
CR +1V +102/23/26, 20:05 -
core-ci voted on patch set 6 V +1 02/23/26, 20:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96614
-
Garvin Hicking voted on patch set 6 CR +1 V +1 02/23/26, 20:25
-
Georg Ringer voted on patch set 6 CR +2 V +2 02/24/26, 07:31
-
Georg Ringer merged patch set 7 02/24/26, 07:31