Review main Abandoned

92898[FEATURE] Add client-side page wizard scaffold with start button

Tobias Wojtylak CR 0 V -1 Nightmare +2418 −173 updated 03/23/26, 07:53

Commit message

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 2

Files 56

Show 36 more files

Review log 72133

Show 56108 earlier messages
  1. Tobias Wojtylak uploaded patch set 1 02/19/26, 14:08

  2. Tobias Wojtylak marked it work in progress 02/19/26, 14:08

  3. core-ci voted on patch set 1 V -1 02/19/26, 14:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96251

  4. Tobias Wojtylak uploaded patch set 2 V -1 02/20/26, 08:23

  5. core-ci voted on patch set 2 V -1 02/20/26, 08:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96315

  6. Tobias Wojtylak uploaded patch set 3 V -1 02/23/26, 16:51

  7. core-ci voted on patch set 3 V -1 02/23/26, 17:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96606

  8. Tobias Wojtylak uploaded patch set 4 V -1 02/24/26, 09:05

  9. core-ci voted on patch set 4 V -1 02/24/26, 09:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96686

  10. Tobias Wojtylak uploaded patch set 5 V -1 02/24/26, 10:49

  11. Tobias Wojtylak uploaded patch set 6 02/24/26, 10:55

  12. Tobias Wojtylak uploaded patch set 7 02/24/26, 11:11

  13. Tobias Wojtylak uploaded patch set 8 02/24/26, 11:22

  14. Tobias Wojtylak uploaded patch set 9 02/24/26, 11:26

  15. core-ci voted on patch set 5 V -1 02/24/26, 11:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96706

  16. core-ci voted on patch set 6 V -1 02/24/26, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96707

  17. core-ci voted on patch set 8 V -1 02/24/26, 11:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96716

  18. core-ci voted on patch set 9 V -1 02/24/26, 12:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96717

  19. Tobias Wojtylak uploaded patch set 10 V -1 02/24/26, 14:43

  20. Tobias Wojtylak uploaded patch set 11 02/24/26, 14:47

  21. Tobias Wojtylak uploaded patch set 12 02/24/26, 14:57

  22. core-ci voted on patch set 11 V -1 02/24/26, 15:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96753

  23. core-ci voted on patch set 10 V -1 02/24/26, 15:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96751

  24. core-ci voted on patch set 12 V -1 02/24/26, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96757

  25. Tobias Wojtylak uploaded patch set 13 V -1 02/24/26, 17:04

  26. core-ci voted on patch set 13 V -1 02/24/26, 17:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96772

  27. Tobias Wojtylak rebased onto patch set 14 V -1 02/25/26, 08:42

  28. core-ci voted on patch set 14 V -1 02/25/26, 08:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96800

  29. Tobias Wojtylak rebased onto patch set 15 V -1 02/26/26, 08:36

  30. core-ci voted on patch set 15 V -1 02/26/26, 08:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96886

  31. Tobias Wojtylak rebased onto patch set 16 V -1 02/26/26, 08:54

  32. core-ci voted on patch set 16 V -1 02/26/26, 09:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96890

  33. Tobias Wojtylak uploaded patch set 17 V -1 02/26/26, 13:12

  34. core-ci voted on patch set 17 V -1 02/26/26, 13:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96918

  35. Tobias Wojtylak uploaded patch set 18 V -1 02/26/26, 13:35

  36. Tobias Wojtylak uploaded patch set 19 02/26/26, 13:41

  37. core-ci voted on patch set 19 V -1 02/26/26, 13:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96922

  38. Tobias Wojtylak uploaded patch set 20 V -1 02/26/26, 13:56

  39. core-ci voted on patch set 20 V +1 02/26/26, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96925

  40. core-ci voted on patch set 18 V -1 02/26/26, 14:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96921

  41. Tobias Wojtylak uploaded patch set 21 V +1 02/27/26, 11:17

  42. core-ci voted on patch set 21 V -1 02/27/26, 11:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96966

  43. Tobias Wojtylak uploaded patch set 22 V -1 03/02/26, 13:00

  44. core-ci voted on patch set 22 V -1 03/02/26, 13:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97106

  45. Tobias Wojtylak uploaded patch set 23 V -1 03/02/26, 13:52

  46. core-ci voted on patch set 23 V -1 03/02/26, 14:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97115

  47. Tobias Wojtylak uploaded patch set 24 V -1 03/02/26, 14:22

  48. core-ci voted on patch set 24 V -1 03/02/26, 14:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97116

  49. Tobias Wojtylak uploaded patch set 25 V -1 03/02/26, 14:46

  50. Tobias Wojtylak uploaded patch set 26 03/02/26, 14:51

  51. Tobias Wojtylak uploaded patch set 27 03/02/26, 14:58

  52. core-ci voted on patch set 26 V -1 03/02/26, 15:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97119

  53. core-ci voted on patch set 25 V -1 03/02/26, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97118

  54. core-ci voted on patch set 26 V -1 03/02/26, 15:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97119

  55. Tobias Wojtylak uploaded patch set 28 03/02/26, 15:11

  56. core-ci voted on patch set 27 V -1 03/02/26, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97121

  57. Tobias Wojtylak uploaded patch set 29 03/02/26, 15:14

  58. core-ci voted on patch set 29 V -1 03/02/26, 15:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97124

  59. core-ci voted on patch set 28 V -1 03/02/26, 15:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97123

  60. Tobias Wojtylak uploaded patch set 30 V -1 03/03/26, 11:05

  61. core-ci voted on patch set 30 V -1 03/03/26, 11:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97168

  62. Tobias Wojtylak uploaded patch set 31 V -1 03/03/26, 11:23

  63. core-ci voted on patch set 31 V -1 03/03/26, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97172

  64. Tobias Wojtylak uploaded patch set 32 V -1 03/03/26, 14:15

  65. core-ci voted on patch set 32 V -1 03/03/26, 14:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97187

  66. Tobias Wojtylak uploaded patch set 33 V -1 03/03/26, 15:11

  67. core-ci voted on patch set 33 V -1 03/03/26, 15:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97193

  68. Tobias Wojtylak uploaded patch set 34 V -1 03/03/26, 16:23

  69. core-ci voted on patch set 34 V -1 03/03/26, 16:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97202

  70. Tobias Wojtylak uploaded patch set 35 V -1 03/03/26, 16:44

  71. core-ci voted on patch set 35 V -1 03/03/26, 17:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97203

  72. Tobias Wojtylak uploaded patch set 36 V -1 03/04/26, 08:34

  73. core-ci voted on patch set 36 V -1 03/04/26, 09:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97271

  74. Tobias Wojtylak uploaded patch set 37 V -1 03/04/26, 09:18

  75. core-ci voted on patch set 37 V -1 03/04/26, 09:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97283

  76. Tobias Wojtylak uploaded patch set 38 V -1 03/04/26, 13:27

  77. core-ci voted on patch set 38 V -1 03/04/26, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97322

  78. Tobias Wojtylak uploaded patch set 39 V -1 03/04/26, 14:04

  79. core-ci voted on patch set 39 V -1 03/04/26, 14:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97327

  80. Tobias Wojtylak uploaded patch set 40 V -1 03/04/26, 15:43

  81. core-ci voted on patch set 40 V -1 03/04/26, 16:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97338

  82. Tobias Wojtylak uploaded patch set 41 V -1 03/05/26, 09:03

  83. core-ci voted on patch set 41 V -1 03/05/26, 09:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97393

  84. Andreas Nedbal uploaded patch set 42 V -1 03/05/26, 09:54

  85. core-ci voted on patch set 42 V -1 03/05/26, 10:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97400

  86. Tobias Wojtylak uploaded patch set 43 V -1 03/06/26, 08:30

  87. core-ci voted on patch set 43 V -1 03/06/26, 09:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97470

  88. Tobias Wojtylak uploaded patch set 44 V -1 03/10/26, 07:24

  89. core-ci voted on patch set 44 V -1 03/10/26, 07:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97651

  90. Tobias Wojtylak uploaded patch set 45 V -1 03/10/26, 09:25

  91. Tobias Wojtylak uploaded patch set 46 03/10/26, 09:41

  92. core-ci voted on patch set 45 V -1 03/10/26, 10:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97657

  93. core-ci voted on patch set 46 V -1 03/10/26, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97661

  94. Tobias Wojtylak rebased onto patch set 47 V -1 03/12/26, 10:22

  95. Tobias Wojtylak rebased onto patch set 48 03/12/26, 10:28

  96. core-ci voted on patch set 48 V -1 03/12/26, 11:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97812

  97. core-ci voted on patch set 47 V -1 03/12/26, 11:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97809

  98. Tobias Wojtylak rebased onto patch set 49 V -1 03/12/26, 12:10

  99. core-ci voted on patch set 49 V -1 03/12/26, 12:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97824

  100. Tobias Wojtylak uploaded patch set 50 V -1 03/12/26, 14:56

  101. core-ci voted on patch set 50 V -1 03/12/26, 15:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97839

  102. Andreas Nedbal commented on patch set 50 CR -1 V +1 03/16/26, 15:30

    This change is ready for review.

    page-wizard-configuration.ts:8

    Please move this type into `page-wizard.ts`, it is coupled to it and is also too small to warrant being extracted into a separate file.

    before-next-step-event.ts:13

    Please move this event into `wizard.ts`, we only have separate files for events if they include additional functionality, extended custom events are usually grouped together with their emitting class/element.
  103. Tobias Wojtylak uploaded patch set 51 CR -1 V +1 03/16/26, 16:44

  104. core-ci voted on patch set 51 V -1 03/16/26, 17:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98038

  105. Tobias Wojtylak marked it work in progress 03/17/26, 13:40

  106. Tobias Wojtylak uploaded patch set 52 V -1 03/17/26, 15:45

  107. Tobias Wojtylak rebased onto patch set 53 03/17/26, 15:46

  108. core-ci voted on patch set 53 V -1 03/17/26, 16:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98104

  1. core-ci voted on patch set 52 V -1 03/17/26, 16:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98102

  2. Tobias Wojtylak rebased onto patch set 54 V -1 03/18/26, 08:48

  3. Tobias Wojtylak uploaded patch set 55 03/18/26, 09:08

  4. Tobias Wojtylak commented on patch set 55 03/18/26, 09:13

    This change is ready for review.

    page-wizard-configuration.ts:8 Reply

    This type is used in multiple files, so keeping it separate avoids unnecessary coupling.

    before-next-step-event.ts:13 Reply

    This event is used in multiple files, so keeping it separate avoids unnecessary coupling and matches with current structure. see also StepSummaryEvent & AutoAdvanceEvent
  5. Tobias Wojtylak uploaded patch set 56 03/18/26, 09:21

  6. core-ci voted on patch set 55 V -1 03/18/26, 09:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98152

  7. Tobias Wojtylak uploaded patch set 57 03/18/26, 09:23

  8. Tobias Wojtylak uploaded patch set 58 03/18/26, 09:29

  9. core-ci voted on patch set 54 V -1 03/18/26, 09:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98149

  10. core-ci voted on patch set 56 V -1 03/18/26, 09:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98153

  11. Josua Vogel commented on patch set 58 03/18/26, 09:44

    Feature rst is missing 😊
  12. Benjamin Franzke commented on patch set 58 03/18/26, 09:50

    Reply

    Ack. FYI: We're still evaluating if we need to squash the patches in this relation (because it only makes sense if all patches get merged), therefore those `*.rst` files will be added once that decision is made how to merge this relation chain.
  13. Benjamin Franzke commented on patch set 58 03/18/26, 09:53

    Reply Unresolved

    because it is essentially one feature, sth like `[FEATURE] Introduce page creation wizard`, see epic: https://forge.typo3.org/issues/108915
  14. core-ci voted on patch set 57 V -1 03/18/26, 10:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98155

  15. core-ci voted on patch set 58 V -1 03/18/26, 10:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98156

  16. Tobias Wojtylak marked it work in progress 03/18/26, 10:13

  17. Garvin Hicking commented on patch set 58 03/19/26, 19:51

    PageWizardController.php:44

    Intentionally not final to allow extension? And public API? (also applies to the other controllers that are new)
  18. Tobias Wojtylak rebased onto patch set 59 V -1 03/20/26, 08:22

  19. core-ci voted on patch set 59 V -1 03/20/26, 08:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98269

  20. Tobias Wojtylak uploaded patch set 60 V -1 03/20/26, 09:58

  21. core-ci voted on patch set 60 V -1 03/20/26, 10:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98283

  22. Tobias Wojtylak commented on patch set 60 03/20/26, 10:35

    PageWizardController.php:44 Reply

    We have decided that the controller should be final and internal. Thank you for your feedback.

    PageWizardController.php:44 Reply Unresolved

    we decided to mark
  23. Tobias Wojtylak uploaded patch set 61 V -1 03/20/26, 12:02

  24. core-ci voted on patch set 61 V -1 03/20/26, 12:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98287

  25. Tobias Wojtylak abandoned the change 03/23/26, 07:53