92902[FEATURE] Localize enum labels in site settings definitions
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Georg Ringer +1
-
Verified V +2 Done
- Garvin Hicking +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+4 −0
- typo3/sysext/backend/Classes/Controller/SiteSettingsController.php+4 −0
- typo3/sysext/backend/Tests/Unit/Controller/SiteConfigurationControllerTest.php2+49 −0
- typo3/sysext/backend/Tests/Unit/Controller/SiteSettingsControllerTest.phpnew+74 −0
- typo3/sysext/core/Classes/Settings/SettingDefinition.php+6 −1
- typo3/sysext/core/Classes/Site/Set/YamlSetDefinitionProvider.php2+56 −6
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-106640-LocalizeEnumLabelsInSiteSettingsDefinitions.rst2new+88 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/SetEnumLabels/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/SetEnumLabels/labels.xlfnew+20 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/SetEnumLabels/settings.definitions.yamlnew+15 −0
- typo3/sysext/core/Tests/Functional/Site/Set/YamlSetDefinitionProviderTest.php+37 −0
Review log 1318
-
Eric Harrer uploaded patch set 1 02/19/26, 17:12
-
Eric Harrer updated the commit message in patch set 2 02/19/26, 17:14
-
core-ci voted on patch set 1 V +1 02/19/26, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96271
-
core-ci voted on patch set 2 V -1 02/19/26, 17:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96272
-
Benjamin Franzke commented on patch set 2 02/19/26, 17:38
-
Eric Harrer uploaded patch set 3
V -102/19/26, 19:15 -
Eric Harrer commented on patch set 3 02/19/26, 19:18
Feature-106640-LocalizeEnumLabelsInSiteSettingsDefinitions.rst:40ReplyThanks for the hint and for pointing me to 92340. I reworked this patch accordingly in the latest patch set: * Enum label handling now follows the mapping approach from 92340 in `YamlSetDefinitionProvider`. List-style enum declarations are normalized to mapped label keys, and `{label}:...` is expanded via the set’s configured labels reference (no hardcoded extension reference needed). * Both `SiteSettingsController` and `SiteConfigurationController` now resolve enum labels via `LanguageService::sL()`, aligned with description label handling. * The previous derived runtime fallback logic in controllers was removed. * Key-only and empty-label enum cases are covered and tested. -
core-ci voted on patch set 3 V +1 02/19/26, 19:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96284
-
Eric Harrer uploaded patch set 4
V +102/19/26, 20:10 -
core-ci voted on patch set 4 V +1 02/19/26, 20:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96288
-
Garvin Hicking commented on patch set 4 02/19/26, 23:43
👍SiteConfigurationControllerTest.php:202(Did not investigate yet) Does the new translation domain syntax (my_site.labels:settings.description.my.enumSetting) work here tok by chance? If so, we should cover it in the test tooYamlSetDefinitionProvider.php:95A comment could help to grasp this monstrosity of synrax sugar ;) -
Eric Harrer uploaded patch set 5
V +102/20/26, 10:23 -
Eric Harrer commented on patch set 5 02/20/26, 10:24
SiteConfigurationControllerTest.php:202ReplyYes, this syntax works in this controller flow as well. I added test coverage for it by using `my_site.labels:settings.description.my.enumSetting` in the unit test setup and asserting the resolved description result.YamlSetDefinitionProvider.php:95ReplyGood point, thanks. I added an inline comment to explain the conversion step: YAML maps are decoded as objects and are normalized to arrays so settings/category definitions can be processed uniformly afterwards. -
core-ci voted on patch set 5 V +1 02/20/26, 10:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96331
-
Garvin Hicking voted on patch set 5 CR +1 V +1 02/20/26, 10:40
-
Georg Ringer voted on patch set 5 CR +1 V +1 02/24/26, 08:11
-
Garvin Hicking voted on patch set 5 CR +2 V +2 03/02/26, 19:20
-
Garvin Hicking merged patch set 6 03/02/26, 19:20
Feature-106640-LocalizeEnumLabelsInSiteSettingsDefinitions.rst:40