92909[TASK] Add language navigation to Camino header
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 12
- typo3/sysext/theme_camino/Configuration/Sets/camino/TypoScript/page.typoscript+6 −0
- typo3/sysext/theme_camino/Documentation/Introduction/Index.rst+11 −0
- typo3/sysext/theme_camino/Resources/Private/Language/messages.xlf+3 −0
- typo3/sysext/theme_camino/Resources/Private/Templates/Partials/Pages/Header.fluid.html2+4 −0
- typo3/sysext/theme_camino/Resources/Private/Templates/Partials/Pages/LanguageNavigation.fluid.htmlnew+84 −0
- typo3/sysext/theme_camino/Resources/Public/Css/_header.css+174 −2
- typo3/sysext/theme_camino/Resources/Public/JavaScript/main.js+81 −0
- typo3/sysext/theme_camino/Tests/Functional/Fixtures/Templates/Pages/Default.fluid.htmlnew+8 −0
- typo3/sysext/theme_camino/Tests/Functional/Fixtures/TypoScript/LanguageNavigationRendering.typoscriptnew+1 −0
- typo3/sysext/theme_camino/Tests/Functional/Fixtures/pages.csvnew+6 −0
- typo3/sysext/theme_camino/Tests/Functional/Rendering/LanguageNavigationRenderingTest.phpnew+86 −0
- composer.json+1 −0
Review log 1215
-
Eric Harrer uploaded patch set 1 02/19/26, 22:36
-
core-ci voted on patch set 1 V -1 02/19/26, 22:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96289
-
Garvin Hicking commented on patch set 1 02/19/26, 23:28
I'm not totally sure how to proceed with camino-related feature changelogs, if we should instead update the single camino related changelog instead. When the theme goes to an extension repository we might have many changelog stubs lying around for it. Resolving this just to have it mentioned.Feature-108786-CaminoAddsFrontendLanguageNavigation.rst:6```suggestion Feature: #108786 - Language navigation support in Camino theme ```Feature-108786-CaminoAddsFrontendLanguageNavigation.rst:14```suggestion The Camino theme now renders a language navigation in the page header. ```Header.fluid.html:32Maybe an own partial (component?) for this is useful? -
Simon Schaufelberger commented on patch set 1 02/20/26, 01:43
Personally I'm not a big fan of Javascript related menus.Reply
I would even consider this a Task as the theme is not there to be used but a showcase. -
Eric Harrer uploaded patch set 2
V -102/20/26, 09:55 -
Eric Harrer commented on patch set 2 02/20/26, 09:58
Reply
JavaScript is already part of the existing Camino header navigation model, especially on mobile (menu open/close and sub-navigation toggling). The language navigation follows this existing interaction pattern and does not introduce a fundamentally new frontend architecture. A JS-free implementation is possible in principle, but it requires a different interaction model (for example always-visible language links or a details/summary-based pattern) and broader markup/CSS changes. This would be a larger refactoring beyond the scope of this patch. From an accessibility perspective, a no-JS approach can be done, but not with the same dropdown behavior and state handling (outside click, Escape handling, ARIA state sync) without structural changes.Reply
I changed the commit type to [TASK], since this is an incremental change to Camino while TYPO3 v14 is still in active development and Camino is currently a showcase/default theme for that cycle. I kept a dedicated 14.2 changelog entry for #108786 and did not merge this into the older 14.1 entry (#108539), to keep release timeline and issue scope clean.Feature-108786-CaminoAddsFrontendLanguageNavigation.rst:6ReplyDoneFeature-108786-CaminoAddsFrontendLanguageNavigation.rst:14ReplyDoneHeader.fluid.html:32ReplyDone -
core-ci voted on patch set 2 V +1 02/20/26, 10:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96329
-
Garvin Hicking commented on patch set 2 V +1 02/20/26, 10:50
Reply
If this commit is a [TASK] we cannot have a Feature-RST for the issue. In that case you would need to rename the feature ReST file to an "important". I however do not think this classifies as "important". Honestly I would just drop the ReST file and append the camino ReST file, that makes more sense than to have this feature ReST. -
Eric Harrer uploaded patch set 3
V +102/20/26, 13:44 -
Eric Harrer commented on patch set 3 02/20/26, 13:45
Reply
Implemented as suggested. - Removed `typo3/sysext/core/Documentation/Changelog/14.2/Feature-108786-CaminoAddsFrontendLanguageNavigation.rst`. - Added a dedicated `Language navigation` section to `typo3/sysext/theme_camino/Documentation/Introduction/Index.rst`. This keeps the change documented in Camino itself and avoids creating another standalone core changelog stub for an incremental Camino update. Also, retroactively editing the original v14.1 Camino feature changelog would be misleading for v14.1 users and would mix release timelines in an unsafer/unclean way, since the language navigation is introduced later in the v14.2 development cycle. -
core-ci voted on patch set 3 V +1 02/20/26, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96354
-
Garvin Hicking commented on patch set 3 CR +1 V +1 02/20/26, 21:00
Reply
Great, that's actually a much better solution now. -
Simon Schaufelberger voted on patch set 3 CR +1 V +1 02/20/26, 21:18
-
Georg Ringer voted on patch set 3 CR +2 V +2 02/24/26, 12:06
-
Georg Ringer merged patch set 4 02/24/26, 12:06