92910[TASK] Deprecate doSave hidden field in FormEngine
Commit message
Review
-
Code review CR +2 Done
- Andreas Nedbal +2
- Oli Bartsch +1
-
Verified V +2 Done
- Andreas Nedbal +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 13
- Build/Sources/TypeScript/backend/form/submit-interceptor.ts+7 −5
- Build/Sources/TypeScript/backend/form-engine.ts3+57 −32
- Build/types/TYPO3/index.d.ts+0 −2
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+3 −5
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+1 −2
- typo3/sysext/backend/Classes/Form/FormAction.php+1 −11
- typo3/sysext/backend/Classes/Form/FormResultCompiler.php+1 −10
- typo3/sysext/backend/Resources/Private/Templates/SiteConfiguration/Edit.fluid.html+0 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form/submit-interceptor.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js+3 −3
- typo3/sysext/backend/Tests/Functional/Controller/EditDocumentControllerAsUserTest.php+1 −1
- typo3/sysext/backend/Tests/Functional/Controller/EditDocumentControllerTest.php+1 −1
- typo3/sysext/core/Documentation/Changelog/14.2/Deprecation-109029-FormEngineDoSaveHiddenField.rstnew+72 −0
Review log 1923
-
Benjamin Kott uploaded patch set 1 02/19/26, 23:59
-
core-ci voted on patch set 1 V +1 02/20/26, 00:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96290
-
Benjamin Franzke commented on patch set 1 02/20/26, 06:01
-
Benjamin Kott commented on patch set 1 02/20/26, 06:40
form-engine.ts:1319Replycan be reproduced with crtl+shift+s hotkey, except on windows where the hotkey does not work -
Oli Bartsch commented on patch set 1 CR -2 02/20/26, 07:28
This seems to be a breaking change to me. Extensions currently rely on `doSave` being sent, when they utilize FormEngine in their components, which is fine as it is not internal. -
Oliver Hader commented on patch set 1 02/20/26, 09:13
Reply
Are you referring to the value sent in the POST body parameter `doSave` (which comes from a `<form>` field)? I would not consider this as internal API. The `FormAction->doSave()` also would not count, since the class is marked `@internal`. -
Benjamin Franzke commented on patch set 1 CR +1 V +1 02/20/26, 09:48
Reply
> I would not consider I guess "not" is a typo here, since you refer to `@internal` afterwards? I agree, I think concrete form names are internal API, basically because we need to be able to move. Otherwise we could start discussions about any form details, like `id`s, hidden field and error management and so forth. -
Oliver Hader commented on patch set 1 02/20/26, 10:06
Reply
Sorry, the `not` was a typo → corrected: > _I would consider this as **internal** API_ or > _I would **not** consider this as **public API**_ -
Andreas Nedbal voted on patch set 1 CR +1 V +1 02/20/26, 12:52
-
Benjamin Franzke commented on patch set 1 02/20/26, 22:46
form-engine.ts:1319Replyack -
Benjamin Franzke commented on patch set 1 02/20/26, 22:48
Reply
Hey @bo@cedev.de we'd like to merge in order to move forward with the page creation wizard.. Will you keep your vote or would you withdraw it? Thanks -
Oli Bartsch commented on patch set 1 02/23/26, 08:51
Reply
@benjamin.kott@outlook.com and I agreed to continue sending this field for v14, but to stop evaluating it in the core. I currently do not see this change. -
Benjamin Kott uploaded patch set 2
CR +1V +102/23/26, 12:14Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Benjamin Kott uploaded patch set 3 02/23/26, 12:15
Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Benjamin Kott commented on patch set 3 02/23/26, 12:23
Reply
@bo@cedev.de i´ve also said that this is stupid, and we should not do it. anyways added migration and a deprecation file now for an internal value, that cannot be considered public api. -
Benjamin Kott commented on patch set 3 02/23/26, 12:23
Reply
done -
core-ci voted on patch set 3 V -1 02/23/26, 12:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96571
-
Oli Bartsch commented on patch set 3 CR +1 V +1 02/23/26, 13:55
Reply
Ok, thank you! -
Andreas Nedbal voted on patch set 3 CR +1 V +1 02/23/26, 14:17
-
core-ci commented on patch set 3 02/23/26, 14:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96571
-
core-ci voted on patch set 3 V +1 02/23/26, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96571
-
Andreas Nedbal voted on patch set 3 CR +2 V +2 02/23/26, 15:13
-
Andreas Nedbal merged patch set 4 02/23/26, 15:13
form-engine.ts:1319