Review main Merged

92910[TASK] Deprecate doSave hidden field in FormEngine

Benjamin Kott CR +2 V +2 Normal +148 −74 updated 02/23/26, 15:13

Commit message

The doSave hidden field was a legacy indirection where JavaScript
set a hidden field to signal PHP that data should be processed.
This is no longer needed since native submit button values like
_savedok are submitted directly.

A submitFormWithAction() helper is introduced to unify programmatic
form submissions. It tries to find a matching submit button for
requestSubmit(), falling back to a dynamic hidden input.

The SubmitInterceptor no longer sets the disabled attribute on the
submitter during the submit event, as this excluded the button value
from form data. A CSS class is used instead for visual feedback,
and duplicate submissions are prevented via e.preventDefault().

For backwards compatibility the doSave field is still appended via
addDeprecatedDoSaveField() in a capture-phase submit listener and
in submitFormWithAction() for save actions (excluding duplication).
The field is deprecated and will be removed in TYPO3 v15.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 1923

  1. Benjamin Kott uploaded patch set 1 02/19/26, 23:59

  2. core-ci voted on patch set 1 V +1 02/20/26, 00:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96290

  3. Benjamin Franzke commented on patch set 1 02/20/26, 06:01

    form-engine.ts:1319

    This you actually ran into this case? And if so: Can we document it, i think it is difficult to reproduce
  4. Benjamin Kott commented on patch set 1 02/20/26, 06:40

    form-engine.ts:1319 Reply

    can be reproduced with crtl+shift+s hotkey, except on windows where the hotkey does not work
  5. Oli Bartsch commented on patch set 1 CR -2 02/20/26, 07:28

    This seems to be a breaking change to me. Extensions currently rely on `doSave` being sent, when they utilize FormEngine in their components, which is fine as it is not internal.
  6. Oliver Hader commented on patch set 1 02/20/26, 09:13

    Reply

    Are you referring to the value sent in the POST body parameter `doSave` (which comes from a `<form>` field)? I would not consider this as internal API. The `FormAction->doSave()` also would not count, since the class is marked `@internal`.
  7. Benjamin Franzke commented on patch set 1 CR +1 V +1 02/20/26, 09:48

    Reply

    > I would not consider I guess "not" is a typo here, since you refer to `@internal` afterwards? I agree, I think concrete form names are internal API, basically because we need to be able to move. Otherwise we could start discussions about any form details, like `id`s, hidden field and error management and so forth.
  8. Oliver Hader commented on patch set 1 02/20/26, 10:06

    Reply

    Sorry, the `not` was a typo → corrected: > _I would consider this as **internal** API_ or > _I would **not** consider this as **public API**_
  9. Andreas Nedbal voted on patch set 1 CR +1 V +1 02/20/26, 12:52

  10. Benjamin Franzke commented on patch set 1 02/20/26, 22:46

    form-engine.ts:1319 Reply

    ack
  11. Benjamin Franzke commented on patch set 1 02/20/26, 22:48

    Reply

    Hey @bo@cedev.de we'd like to merge in order to move forward with the page creation wizard.. Will you keep your vote or would you withdraw it? Thanks
  12. Oli Bartsch commented on patch set 1 02/23/26, 08:51

    Reply

    @benjamin.kott@outlook.com and I agreed to continue sending this field for v14, but to stop evaluating it in the core. I currently do not see this change.
  13. Benjamin Kott uploaded patch set 2 CR +1 V +1 02/23/26, 12:14

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  14. Benjamin Kott uploaded patch set 3 02/23/26, 12:15

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  15. Benjamin Kott commented on patch set 3 02/23/26, 12:23

    Reply

    @bo@cedev.de i´ve also said that this is stupid, and we should not do it. anyways added migration and a deprecation file now for an internal value, that cannot be considered public api.
  16. Benjamin Kott commented on patch set 3 02/23/26, 12:23

    Reply

    done
  17. core-ci voted on patch set 3 V -1 02/23/26, 12:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96571

  18. Oli Bartsch commented on patch set 3 CR +1 V +1 02/23/26, 13:55

    Reply

    Ok, thank you!
  19. Andreas Nedbal voted on patch set 3 CR +1 V +1 02/23/26, 14:17

  20. core-ci commented on patch set 3 02/23/26, 14:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96571

  21. core-ci voted on patch set 3 V +1 02/23/26, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96571

  22. Andreas Nedbal voted on patch set 3 CR +2 V +2 02/23/26, 15:13

  23. Andreas Nedbal merged patch set 4 02/23/26, 15:13