Review main Merged

92912[TASK] Adapt TypeScript label type generation for xlf files with hyphens

Benjamin Franzke CR +2 V +2 Easy +5 −13 updated 03/16/26, 10:22

Commit message

The changes in #109025 revealed that .xlf files that contain
hyphens have not been transformed to the proper language
domain notation as defined in `TranslationDomainMapper`.

This went unnoticed, because we allowed a generic label
import as a fallback, that allowed all labels to pass.
This quirk was intended to avoid errors in IDE's
prior to the first build invocation, but it turned out
to be more harmful than useful.

We now remove this lax handling and instead require
all label imports to be actually resolvable.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1318

  1. Benjamin Franzke uploaded patch set 1 02/20/26, 08:14

  2. core-ci voted on patch set 1 V +1 02/20/26, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96313

  3. Benjamin Franzke rebased onto patch set 2 V +1 02/20/26, 21:09

  4. core-ci voted on patch set 2 V +1 02/20/26, 21:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96407

  5. Benjamin Franzke rebased onto patch set 3 V +1 02/20/26, 22:04

  6. Benjamin Franzke wrote 02/20/26, 22:04

    Hashtag added: labels
  7. core-ci voted on patch set 3 V +1 02/20/26, 22:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96411

  8. Benjamin Franzke updated the commit message in patch set 4 V +1 02/21/26, 19:01

  9. core-ci voted on patch set 4 V +1 02/21/26, 19:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96466

  10. Andreas Kienast voted on patch set 4 CR +1 02/23/26, 06:31

  11. Benjamin Franzke rebased onto patch set 5 CR +1 V +1 02/23/26, 07:20

  12. core-ci voted on patch set 5 V +1 02/23/26, 07:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96535

  13. Andreas Kienast voted on patch set 5 CR +1 02/23/26, 08:33

  14. Andreas Kienast voted on patch set 5 V +1 02/23/26, 08:35

  15. Benjamin Kott voted on patch set 5 CR +1 V +1 02/23/26, 09:19

  16. Benjamin Franzke voted on patch set 5 CR +2 V +2 02/23/26, 09:19

  17. Benjamin Franzke merged patch set 6 02/23/26, 09:20

  18. Garvin Hicking commented on patch set 6 03/16/26, 10:22

    Unresolved

    (Typo in the "Releases" line)