Review 13.4 Merged

92924[BUGFIX] Prevent PHP 8.5 null as array offset notice in Settings API

Garvin Hicking CR +2 V +2 Easy +1 −1 updated 02/20/26, 14:25

Commit message

A settings.definitions.yaml setting without a category assignment
leads to a 'null' value that is checked in an
`isset($categories[null])` assignment. This throws a deprecation
notice in PHP 8.5.

This patch instead uses an empty string as fallback.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Garvin Hicking commented on patch set 1 02/20/26, 13:25

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/20/26, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96350

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 02/20/26, 14:25

  4. Garvin Hicking merged patch set 2 02/20/26, 14:25