92925[TASK] Support ICU MessageFormat in JavaScript label API
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Benjamin Kott +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Benjamin Kott +1
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 28
- Build/lib/generate-label-types.js+52 −2
- Build/Sources/TypeScript/backend/form-engine/element/extra/char-counter.ts+1 −1
- Build/Sources/TypeScript/backend/localization/label-provider.ts+126 −4
- Build/Sources/TypeScript/backend/tests/localization/label-provider-test.ts2new+72 −0
- Build/Sources/TypeScript/backend/type/date-configuration.ts+2 −0
- Build/Sources/TypeScript/backend/form-engine.ts+3 −1
- Build/Sources/TypeScript/extensionmanager/repository.ts+6 −6
- Build/Sources/TypeScript/filelist/rename-file.ts+4 −3
- Build/Sources/TypeScript/form/backend/form-manager/view-model.ts+5 −5
- Build/Sources/TypeScript/workspaces/renderable/record-information.ts+2 −3
- Build/Sources/TypeScript/workspaces/backend.ts+3 −1
- Build/Gruntfile.js+1 −0
- Build/package-lock.json+71 −1
- Build/package.json+1 −0
- Build/web-test-runner.config.mjs+1 −0
- typo3/sysext/backend/Classes/Date/DateConfigurationFactory.php+1 −0
- typo3/sysext/backend/Classes/Date/DateFormats.php+2 −0
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/extra/char-counter.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/localization/label-provider.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js+1 −1
Show 8 more files
- typo3/sysext/core/Configuration/JavaScriptModules.php+1 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-108941-ProvideLanguageLabelsAsVirtualJavaScriptModules.rst+12 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/intl-messageformat.jsnew+3 −0
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/repository.js+3 −3
- typo3/sysext/filelist/Resources/Public/JavaScript/rename-file.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-manager/view-model.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/renderable/record-information.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js+1 −1
Review log 2950
Show 1325 earlier messages
-
Benjamin Franzke uploaded patch set 1 02/20/26, 13:58
-
Benjamin Franzke commented on patch set 1 02/20/26, 14:02
We may also see if we can remove the `%s/%d` parsing in here and only support ICU labels. I'd probably wait to see how many usages we have in JS in total and decide based on that, since that means we need to create new labels for the ones that need to be migrated. -
Benjamin Franzke wrote 02/20/26, 14:05
Hashtag added: labels -
core-ci voted on patch set 1 V -1 02/20/26, 14:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96357
-
core-ci commented on patch set 1 02/20/26, 15:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96357
-
Benjamin Franzke updated the commit message in patch set 2
V -102/20/26, 15:24 -
core-ci voted on patch set 2 V +1 02/20/26, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96372
-
Benjamin Franzke uploaded patch set 3
V +102/20/26, 21:09 -
core-ci voted on patch set 3 V -1 02/20/26, 21:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96408
-
core-ci commented on patch set 3 02/20/26, 21:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96408
-
core-ci commented on patch set 3 02/20/26, 21:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96408
-
Benjamin Franzke uploaded patch set 4
V -102/20/26, 22:04 -
Benjamin Franzke commented on patch set 4 02/20/26, 22:07
Reply
will keep for now. -
core-ci voted on patch set 4 V -1 02/20/26, 22:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96412
-
Benjamin Franzke uploaded patch set 5
V -102/21/26, 01:16 -
core-ci voted on patch set 5 V +1 02/21/26, 01:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96424
-
Benjamin Franzke rebased onto patch set 6
V +102/21/26, 08:59 -
core-ci voted on patch set 6 V +1 02/21/26, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96438
-
Benjamin Franzke uploaded patch set 7
V +102/21/26, 09:37 -
core-ci voted on patch set 7 V +1 02/21/26, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96442
-
Benjamin Franzke uploaded patch set 8
V +102/21/26, 15:43 -
Benjamin Franzke uploaded patch set 9 02/21/26, 15:49
-
core-ci voted on patch set 8 V +1 02/21/26, 16:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96455
-
core-ci voted on patch set 9 V +1 02/21/26, 16:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96457
-
Benjamin Franzke uploaded patch set 10
V +102/21/26, 16:38
-
Benjamin Franzke uploaded patch set 11 02/21/26, 16:40
-
Benjamin Franzke uploaded patch set 12 02/21/26, 16:48
-
core-ci voted on patch set 10 V +1 02/21/26, 16:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96461
-
core-ci voted on patch set 11 V +1 02/21/26, 16:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96462
-
core-ci voted on patch set 12 V +1 02/21/26, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96463
-
Benjamin Franzke uploaded patch set 13
V +102/21/26, 19:01 -
core-ci voted on patch set 13 V +1 02/21/26, 19:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96468
-
Benjamin Franzke rebased onto patch set 14
V +102/23/26, 10:19 -
core-ci voted on patch set 14 V -1 02/23/26, 10:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96551
-
core-ci voted on patch set 14 V +1 02/23/26, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96551
-
Benni Mack voted on patch set 14 CR +1 V +1 02/23/26, 20:15
-
Benjamin Franzke uploaded patch set 15
CR +1V +102/23/26, 20:54Resolve Merge-Conflict -
core-ci voted on patch set 15 V +1 02/23/26, 21:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96617
-
Benni Mack voted on patch set 15 CR +1 V +1 02/23/26, 21:19
-
Benjamin Kott commented on patch set 15 02/23/26, 21:29
label-provider-test.ts:65this does not respect the date and time config of the backend -
Benjamin Franzke uploaded patch set 16
CR +1V +102/23/26, 22:40 -
Benjamin Franzke commented on patch set 16 02/23/26, 22:40
label-provider-test.ts:65ReplyI've now mapped the "medium" preset to SYS.ddmmyy and SYS.hhmm. We do not have a corresponding setting for the date/time Intl presets short/long/full. I'd like to replace the entirety of configuring formats by configuring time-locales in future – see https://review.typo3.org/c/Packages/TYPO3.CMS/+/85262 – in order basically always use locale-based mapping. Anyway, supporting "medium" should be fine for now. Note that timezones were already respected. -
core-ci voted on patch set 16 V +1 02/23/26, 22:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96655
-
Benni Mack voted on patch set 16 CR +1 V +1 02/24/26, 07:48
-
Benjamin Franzke uploaded patch set 17
CR +1V +102/24/26, 08:07 -
core-ci voted on patch set 17 V +1 02/24/26, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96680
-
Benni Mack voted on patch set 17 CR +1 V +1 02/24/26, 08:47
-
Benjamin Kott voted on patch set 17 CR +1 V +1 02/24/26, 10:13
-
Benjamin Franzke voted on patch set 17 CR +2 V +2 02/24/26, 10:14
-
Benjamin Franzke merged patch set 18 02/24/26, 10:14