Review main Merged

92935[TASK] Generate types for placeholders in JavaScript label API

Benjamin Franzke CR +2 V +2 Normal +148 −53 updated 02/23/26, 20:43

Commit message

Ensure that placeholders, that are passed to the label provider
in TypeScript label calls, match the shape (types and amount)
of the placeholders that are actually defined in the respective
labels in xliff files.

Technically the label placeholders are now passed as an array instead
of using variables arguments. This is done to prepare for passing
objects with named keys (e.g. ICU Message Format) instead of
positional arguments.

Existing misusages in form-engine and rename-file are adapted to use
`replace()` to apply `{0}` substitution for now (we have no
implementation for curly bracket placeholders yet, that will follow
with ICU Message Format support later on).

Commands executed:

  npm install --save-dev sax
  npm run build

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 27

Show 7 more files

Review log 1624

  1. Benjamin Franzke uploaded patch set 1 02/20/26, 22:04

  2. Benjamin Franzke wrote 02/20/26, 22:04

    Hashtag added: labels
  3. core-ci voted on patch set 1 V -1 02/20/26, 22:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96415

  4. Benjamin Franzke updated the commit message in patch set 2 V -1 02/20/26, 22:50

  5. core-ci voted on patch set 2 V -1 02/20/26, 23:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96418

  6. Benjamin Franzke uploaded patch set 3 V -1 02/21/26, 01:14

  7. core-ci voted on patch set 3 V -1 02/21/26, 01:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96423

  8. Benjamin Franzke uploaded patch set 4 V -1 02/21/26, 08:54

  9. core-ci voted on patch set 4 V +1 02/21/26, 09:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96437

  10. Benjamin Franzke uploaded patch set 5 V +1 02/21/26, 09:37

  11. core-ci voted on patch set 5 V +1 02/21/26, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96441

  12. Benjamin Franzke uploaded patch set 6 02/21/26, 19:01

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  13. core-ci voted on patch set 6 V +1 02/21/26, 19:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96467

  14. Benjamin Franzke commented on patch set 6 CR -1 02/23/26, 07:11

    generate-label-types.js:5

    This need to implement xliff 2.0 as well (example typo3/sysext/scheduler/Resources/Private/Language/label.xlf)
  15. Benjamin Franzke uploaded patch set 7 CR -1 V +1 02/23/26, 07:20

  16. Benjamin Franzke commented on patch set 7 02/23/26, 07:20

    generate-label-types.js:5 Reply

    Done
  17. core-ci voted on patch set 7 V +1 02/23/26, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96536

  18. Benni Mack voted on patch set 7 CR +1 V +1 02/23/26, 18:59

  19. Benjamin Franzke uploaded patch set 8 CR +1 V +1 02/23/26, 19:44

    Resolve Merge-Conflict
  20. core-ci voted on patch set 8 V +1 02/23/26, 19:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96613

  21. Benni Mack voted on patch set 8 CR +1 V +1 02/23/26, 20:06

  22. Benjamin Kott voted on patch set 8 CR +1 V +1 02/23/26, 20:43

  23. Benjamin Kott voted on patch set 8 CR +2 V +2 02/23/26, 20:43

  24. Benjamin Kott merged patch set 9 02/23/26, 20:43