92936[BUGFIX] Undefined array key in registry migration wizard
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Christian Kuhn +1
-
Verified V +2 Done
- Garvin Hicking +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 12
- typo3/sysext/backend/Classes/Upgrades/UserSettingsMigration.php+1 −0
- typo3/sysext/core/Classes/Upgrades/MigrateExtensionDataImportRegistryKeysUpdate.php+8 −1
- typo3/sysext/core/Classes/Upgrades/SysFileMimeTypeMigration.php+1 −0
- typo3/sysext/core/DeprecatedClasses/ext-install/Attribute/UpgradeWizard.php+1 −1
- typo3/sysext/core/DeprecatedClasses/ext-install/Updates/AbstractListTypeToCTypeUpdate.php+1 −1
- typo3/sysext/core/DeprecatedClasses/ext-install/Updates/ChattyInterface.php+1 −1
- typo3/sysext/core/DeprecatedClasses/ext-install/Updates/ConfirmableInterface.php+1 −1
- typo3/sysext/core/DeprecatedClasses/ext-install/Updates/Confirmation.php+1 −1
- typo3/sysext/core/DeprecatedClasses/ext-install/Updates/PrerequisiteInterface.php+1 −1
- typo3/sysext/core/DeprecatedClasses/ext-install/Updates/RepeatableInterface.php+1 −1
- typo3/sysext/core/DeprecatedClasses/ext-install/Updates/UpgradeWizardInterface.php+1 −1
- typo3/sysext/form/Classes/Upgrades/FileFormsToDatabaseUpgradeWizard.php+1 −0
Review log 1014
-
Benoit Chenu uploaded patch set 1 02/20/26, 23:54
-
core-ci voted on patch set 1 V +1 02/21/26, 00:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96420
-
Garvin Hicking commented on patch set 1 02/21/26, 08:34
how about instead doing a If ($pathKey === '') return null as early gating. That would prevent increase if nesting complexity and be more explicit, and do less unneeded checks. Thanks for the patch! -
Garvin Hicking uploaded patch set 2
V +104/14/26, 17:47 -
Garvin Hicking commented on patch set 2 CR +1 V +1 04/14/26, 17:48
Reply
Done -
core-ci voted on patch set 2 V +1 04/14/26, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100188
-
Garvin Hicking uploaded patch set 3
CR +1V +104/14/26, 18:13 -
Garvin Hicking uploaded patch set 4 04/14/26, 18:18
-
Garvin Hicking commented on patch set 4 CR +1 V +1 04/14/26, 18:19
Trying to put a lid on this rabbit hole :D -
Christian Kuhn commented on patch set 4 CR +1 V +1 04/14/26, 18:23
fine with me to fix the issue for now. i kinda have the feeling as if edge cases are still not handled well enough and especially updateNecessary() may trigger over and over again on funny cases. this could have another look, but i think we should pick this already. -
core-ci voted on patch set 3 V +1 04/14/26, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100192
-
core-ci voted on patch set 4 V +1 04/14/26, 18:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100193
-
Garvin Hicking voted on patch set 4 CR +2 V +2 04/14/26, 18:56
-
Garvin Hicking merged patch set 5 04/14/26, 18:56