Review main Merged

92936[BUGFIX] Undefined array key in registry migration wizard

Benoit Chenu CR +2 V +2 Easy +19 −9 updated 04/14/26, 18:56

Commit message

The sys_registry migration [1] might fail on rows that are
missing valid path entries. The checks are now adapted to
be more robust on the string expectations.

This may need revisiting in the future if "unexpected"
registry keys prevent the wizard from ever finished.
Needs more specific examples on what ended up in
database rows.

As a drive-by, the @since notation was updated in
some places, and a TYPO34 typo was typofixed.

[1] `MigrateExtensionDataImportRegistryKeysUpdate`

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 12

Review log 1014

  1. Benoit Chenu uploaded patch set 1 02/20/26, 23:54

  2. core-ci voted on patch set 1 V +1 02/21/26, 00:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96420

  3. Garvin Hicking commented on patch set 1 02/21/26, 08:34

    how about instead doing a If ($pathKey === '') return null as early gating. That would prevent increase if nesting complexity and be more explicit, and do less unneeded checks. Thanks for the patch!
  4. Garvin Hicking uploaded patch set 2 V +1 04/14/26, 17:47

  5. Garvin Hicking commented on patch set 2 CR +1 V +1 04/14/26, 17:48

    Reply

    Done
  6. core-ci voted on patch set 2 V +1 04/14/26, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100188

  7. Garvin Hicking uploaded patch set 3 CR +1 V +1 04/14/26, 18:13

  8. Garvin Hicking uploaded patch set 4 04/14/26, 18:18

  9. Garvin Hicking commented on patch set 4 CR +1 V +1 04/14/26, 18:19

    Trying to put a lid on this rabbit hole :D
  10. Christian Kuhn commented on patch set 4 CR +1 V +1 04/14/26, 18:23

    fine with me to fix the issue for now. i kinda have the feeling as if edge cases are still not handled well enough and especially updateNecessary() may trigger over and over again on funny cases. this could have another look, but i think we should pick this already.
  11. core-ci voted on patch set 3 V +1 04/14/26, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100192

  12. core-ci voted on patch set 4 V +1 04/14/26, 18:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100193

  13. Garvin Hicking voted on patch set 4 CR +2 V +2 04/14/26, 18:56

  14. Garvin Hicking merged patch set 5 04/14/26, 18:56