Review main Abandoned

92937[TASK] Fix some flaky Playwright e2e tests

Benni Mack CR 0 V -1 Normal +117 −89 updated 03/24/26, 09:50

Commit message

CI tests still ran with 2 retries due to flaky tests,
which had implicit waits and fragile iframe reload detections.

These are now replaced with explicit responses waits using
waitForModuleResponse() across multiple tests:

1. configuration-module-provider: Wait for module response after
   dropdown selection to avoid race conditions.

2. file-clipboard: Add beforeEach visibility check for clipboard
   panel, replace cestIsOldPage iframe detection with
   waitForModuleResponse().

3. recycler-module: Split up into multiple tests in order to
   skip the timeout of the AJAX call.

4. qrcode-module: Use formEngine.save()/close() helpers instead
   of raw button clicks, add formEngineLoaded() wait

5. redirects-module: Add missing await on selectInDropDown()

6. workspaces: Adapt to new calls without timeouts.

The retries in the e2e playwright config are now disabled to show
even more flaky tests.

The change was created with the help of AI due to re-running and
fixing especially the recycler-module tests.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 8

Review log 917

  1. Benni Mack uploaded patch set 1 02/21/26, 07:35

  2. core-ci voted on patch set 1 V -1 02/21/26, 07:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96435

  3. Benni Mack uploaded patch set 2 V -1 02/21/26, 08:10

  4. core-ci voted on patch set 2 V -1 02/21/26, 08:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96436

  5. Benni Mack uploaded patch set 3 V -1 02/21/26, 12:04

  6. core-ci voted on patch set 3 V -1 02/21/26, 12:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96448

  7. Benjamin Franzke uploaded patch set 4 V -1 02/23/26, 15:43

  8. core-ci voted on patch set 4 V -1 02/23/26, 16:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96597

  9. Benjamin Franzke rebased onto patch set 5 V -1 02/23/26, 20:38

  10. core-ci voted on patch set 5 V -1 02/23/26, 20:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96616

  11. Benjamin Franzke rebased onto patch set 6 V -1 02/25/26, 15:30

  12. core-ci voted on patch set 6 V -1 02/25/26, 15:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96836

  13. Sven Liebert rebased onto patch set 7 V -1 02/28/26, 16:21

  14. core-ci voted on patch set 7 V -1 02/28/26, 16:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97029

  15. Sven Liebert rebased onto patch set 8 V -1 03/17/26, 08:55

  16. core-ci voted on patch set 8 V -1 03/17/26, 09:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98077

  17. Garvin Hicking abandoned the change 03/24/26, 09:50