Review main Merged

92945[BUGFIX] Prevent undefined array key in BackendLayoutWizardElement

Stefan Froemken CR +2 V +2 Easy +1 −13 updated 02/24/26, 20:08

Commit message

When saving a new Backend Layout record that does not utilize
colSpan or rowSpan, the spannedMatrix for a given row might not
be initialized. This leads to a PHP Warning "Undefined array key"
when the wizard attempts to sort the spanned matrix during
initialization.

By using the null coalescing operator, we ensure that the check
safely handles cases where the row index does not exist in the
matrix.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Stefan Froemken uploaded patch set 1 02/21/26, 21:57

  2. core-ci voted on patch set 1 V -1 02/21/26, 22:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96474

  3. Stefan Froemken uploaded patch set 2 V -1 02/21/26, 23:06

  4. core-ci voted on patch set 2 V +1 02/21/26, 23:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96476

  5. Oliver Klee voted on patch set 2 CR +1 02/22/26, 15:17

  6. Oliver Klee commented on patch set 2 02/22/26, 15:18

    Is main the only branch affected, or should we have any backports?
  7. Stefan Froemken commented on patch set 2 02/24/26, 19:43

    Reply

    It will only affect main branch. In earlier TYPO3 versions that part was checked via "empty()" and hi hi, you have voted with +1 to add the PhpStan modifications from Bennis patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/92890 ;-)
  8. Georg Ringer voted on patch set 2 CR +1 V +1 02/24/26, 19:48

  9. Garvin Hicking commented on patch set 2 CR +2 V +2 02/24/26, 20:08

    Reply

    Done
  10. Garvin Hicking merged patch set 3 02/24/26, 20:08