92949[TASK] Allow JavaScript label API usage in install tool
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Sven Liebert +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Sven Liebert +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/backend/Classes/Controller/JavaScriptLanguageDomainController.php+3 −36
- typo3/sysext/core/Classes/Localization/JavaScriptLanguageDomainProvider.php3new+67 −0
- typo3/sysext/core/Classes/Page/ImportMap.php+1 −0
- typo3/sysext/install/Classes/Controller/InstallerController.php+3 −7
- typo3/sysext/install/Classes/Controller/LayoutController.php+3 −9
- typo3/sysext/install/Classes/Factory/ImportMapFactory.phpnew+84 −0
- typo3/sysext/install/Classes/Middleware/JavaScriptLanguageDomainProvider.phpnew+72 −0
- typo3/sysext/install/Classes/ServiceProvider.php+22 −1
- typo3/sysext/install/Configuration/JavaScriptModules.php1+12 −0
Review log 1621
-
Benjamin Franzke uploaded patch set 1 02/22/26, 13:24
-
core-ci voted on patch set 1 V -1 02/22/26, 13:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96500
-
Benjamin Franzke uploaded patch set 2
V -102/22/26, 14:05 -
Benjamin Franzke uploaded patch set 3 02/22/26, 14:22
-
core-ci voted on patch set 2 V -1 02/22/26, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96501
-
Benjamin Franzke wrote 02/22/26, 14:23
Hashtag added: labels -
core-ci voted on patch set 3 V +1 02/22/26, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96508
-
Benjamin Franzke rebased onto patch set 4
V +102/23/26, 10:19 -
core-ci voted on patch set 4 V +1 02/23/26, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96553
-
Benni Mack commented on patch set 4 02/23/26, 16:57
EventDispatcher.php:57let us please mark this method internal... I never want people to officially know they can modify the listener provider ;) -
Benjamin Franzke commented on patch set 4 02/23/26, 17:15
EventDispatcher.php:57Replyah sh…, thx for finding, this is a left-over. I'll remove it. -
Benjamin Franzke uploaded patch set 5
V +102/23/26, 17:17 -
Benjamin Franzke commented on patch set 5 02/23/26, 17:17
EventDispatcher.php:57ReplyThis was a first hack, but I then decided to use an anonymous class to avoid introducing this function, but then forgot to remove it. Done. -
core-ci voted on patch set 5 V +1 02/23/26, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96610
-
Sven Liebert voted on patch set 5 CR +1 V +1 02/23/26, 18:07
-
Benni Mack commented on patch set 5 02/23/26, 18:20
JavaScriptLanguageDomainProvider.php:50note for later: we should move the label-provider.js into EXT:core -
Benjamin Franzke commented on patch set 5 02/23/26, 19:06
JavaScriptLanguageDomainProvider.php:50Replyack, we can do that. Since we currently only have a server-side provider in EXT:backend I didn't want to provide it "too" early in frontend. -
Benni Mack commented on patch set 5 02/23/26, 20:22
JavaScriptModules.php:14typo. "can NOT be used". -
Benni Mack voted on patch set 5 CR +1 V +1 02/23/26, 20:22
-
Benjamin Franzke commented on patch set 5 CR +2 V +2 02/23/26, 20:57
JavaScriptLanguageDomainProvider.php:50ReplyDone -
Benjamin Franzke merged patch set 6 02/23/26, 20:57