Review main Merged

92949[TASK] Allow JavaScript label API usage in install tool

Benjamin Franzke CR +2 V +2 Hard +267 −53 updated 02/23/26, 20:57

Commit message

The install tool makes use of certain JavaScript components
for EXT:backend, which requires to allow resolution of '~labels/*'
imports for these components.

A designated label provider now allows to fetch labels
from core, backend and install. Other extensions are not allowed.

Available labels need to be configured explicitly, as we can
not use path based forward trailing-slash imports (which require
rewrite rules) since we can not rely on rewrite rules to be available
when TYPO3 is initially installed or in case the maintenance tool
needs to be used in a otherwise broken installation.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Sven Liebert +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Sven Liebert +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1621

  1. Benjamin Franzke uploaded patch set 1 02/22/26, 13:24

  2. core-ci voted on patch set 1 V -1 02/22/26, 13:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96500

  3. Benjamin Franzke uploaded patch set 2 V -1 02/22/26, 14:05

  4. Benjamin Franzke uploaded patch set 3 02/22/26, 14:22

  5. core-ci voted on patch set 2 V -1 02/22/26, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96501

  6. Benjamin Franzke wrote 02/22/26, 14:23

    Hashtag added: labels
  7. core-ci voted on patch set 3 V +1 02/22/26, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96508

  8. Benjamin Franzke rebased onto patch set 4 V +1 02/23/26, 10:19

  9. core-ci voted on patch set 4 V +1 02/23/26, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96553

  10. Benni Mack commented on patch set 4 02/23/26, 16:57

    EventDispatcher.php:57

    let us please mark this method internal... I never want people to officially know they can modify the listener provider ;)
  11. Benjamin Franzke commented on patch set 4 02/23/26, 17:15

    EventDispatcher.php:57 Reply

    ah sh…, thx for finding, this is a left-over. I'll remove it.
  12. Benjamin Franzke uploaded patch set 5 V +1 02/23/26, 17:17

  13. Benjamin Franzke commented on patch set 5 02/23/26, 17:17

    EventDispatcher.php:57 Reply

    This was a first hack, but I then decided to use an anonymous class to avoid introducing this function, but then forgot to remove it. Done.
  14. core-ci voted on patch set 5 V +1 02/23/26, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96610

  15. Sven Liebert voted on patch set 5 CR +1 V +1 02/23/26, 18:07

  16. Benni Mack commented on patch set 5 02/23/26, 18:20

    JavaScriptLanguageDomainProvider.php:50

    note for later: we should move the label-provider.js into EXT:core
  17. Benjamin Franzke commented on patch set 5 02/23/26, 19:06

    JavaScriptLanguageDomainProvider.php:50 Reply

    ack, we can do that. Since we currently only have a server-side provider in EXT:backend I didn't want to provide it "too" early in frontend.
  18. Benni Mack commented on patch set 5 02/23/26, 20:22

    JavaScriptModules.php:14

    typo. "can NOT be used".
  19. Benni Mack voted on patch set 5 CR +1 V +1 02/23/26, 20:22

  20. Benjamin Franzke commented on patch set 5 CR +2 V +2 02/23/26, 20:57

    JavaScriptLanguageDomainProvider.php:50 Reply

    Done
  21. Benjamin Franzke merged patch set 6 02/23/26, 20:57