Review main Merged

92952[BUGFIX] Fix tab order of toolbar buttons

Richard Krikler CR +2 V +2 Easy +2 −24 updated 03/03/26, 06:56

Commit message

The focus order of the toolbar buttons e.g. page tab ("New page",
"Download", "Show columns") did not match their visual order.

This behavior is due to the manually configured visual order in SCSS.

Content in the DOM should be ordered equal to the visual order to
ensure correct tab order. [1]

To solve this issue the manual ordering in SCSS is removed & correctly
defined in `DatabaseRecordList.php`.

Commands executed:
  ./Build/Scripts/runTests.sh -s build

[1] https://www.w3.org/WAI/WCAG21/Techniques/css/C27

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1013

  1. Richard Krikler uploaded patch set 1 02/22/26, 19:13

  2. core-ci voted on patch set 1 V +1 02/22/26, 19:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96522

  3. Georg Ringer voted on patch set 1 CR +1 V +1 02/23/26, 08:29

  4. Josef Glatz voted on patch set 1 V +1 02/23/26, 09:23

  5. Richard Krikler rebased onto patch set 2 CR +1 V +1 02/27/26, 07:59

  6. core-ci voted on patch set 2 V +1 02/27/26, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96953

  7. Simon Schaufelberger voted on patch set 2 CR +1 V +1 02/27/26, 10:29

  8. Georg Ringer updated the commit message in patch set 3 CR +1 V +1 03/02/26, 19:27

  9. Georg Ringer commented on patch set 3 CR +1 V +1 03/02/26, 19:27

    main only as changing the ui with patch releases can surprise editors and mismatch with generated manuals
  10. core-ci voted on patch set 3 V +1 03/02/26, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97132

  11. Simon Schaufelberger voted on patch set 3 CR +1 V +1 03/02/26, 20:47

  12. Georg Ringer voted on patch set 3 CR +2 V +2 03/03/26, 06:56

  13. Georg Ringer merged patch set 4 03/03/26, 06:56