Review main Merged

92954[BUGFIX] Fix preselection in page browser/tree component

Tobias Wojtylak CR +2 V +2 Easy +3 −3 updated 02/24/26, 11:40

Commit message

Preselection was not applied because the handlers were registered via
the `tree:initialized` event, which is fired after loading data.

Now, the `typo3:tree:node-selected` and `typo3:tree:nodes-prepared`
handlers are registered directly on the tree, ensuring the active page
is marked correctly.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1

Issues 1

Files 2

Review log 1322

  1. Tobias Wojtylak uploaded patch set 1 02/23/26, 08:21

  2. Tobias Wojtylak updated the commit message in patch set 2 02/23/26, 08:23

  3. core-ci voted on patch set 1 V +1 02/23/26, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96542

  4. core-ci voted on patch set 2 V +1 02/23/26, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96543

  5. Tobias Wojtylak rebased onto patch set 3 V +1 02/23/26, 16:51

  6. core-ci voted on patch set 3 V +1 02/23/26, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96604

  7. Benjamin Kott commented on patch set 3 CR -1 02/24/26, 07:26

    tree.ts:747

    this is not correct and needs to be replaced, the problem is in the page browser. the events in the page browser needs to be registered early and not after tree:initialized @typo3:tree:node-selected=${this.loadRecordsOfPage} @typo3:tree:nodes-prepared=${this.selectActivePageInTree} @tree:initialized=${initialized}
  8. Tobias Wojtylak commented on patch set 3 02/24/26, 08:05

    tree.ts:747 Reply

    Changed it. Yes, of course this solution works as well. In my opinion, the flow in the tree is still a bit off. Initialization should happen first, and then loadData.
  9. Tobias Wojtylak uploaded patch set 4 CR -1 V +1 02/24/26, 08:05

  10. core-ci voted on patch set 4 V -1 02/24/26, 08:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96679

  11. core-ci voted on patch set 4 V +1 02/24/26, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96679

  12. Tobias Wojtylak rebased onto patch set 5 V +1 02/24/26, 09:05

  13. core-ci voted on patch set 5 V -1 02/24/26, 10:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96684

  14. Benjamin Franzke commented on patch set 5 02/24/26, 10:22

    I've restarted the failed jobs.
  15. Benjamin Franzke voted on patch set 5 CR +1 V +1 02/24/26, 10:27

  16. core-ci commented on patch set 5 02/24/26, 10:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96684

  17. core-ci commented on patch set 5 02/24/26, 11:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96684

  18. Tobias Wojtylak uploaded patch set 6 CR +1 V +1 02/24/26, 11:11

  19. Benjamin Franzke voted on patch set 6 CR +1 V +1 02/24/26, 11:15

  20. Benjamin Kott voted on patch set 6 CR +2 V +2 02/24/26, 11:16

  21. Benjamin Kott merged patch set 7 02/24/26, 11:16

  22. core-ci voted on patch set 6 V +1 02/24/26, 11:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96713