Review main Merged

92963[BUGFIX] Adjust type declaration to AbstractAuthenticationService

Garvin Hicking CR +2 V +2 Easy +9 −3 updated 02/24/26, 08:39

Commit message

The cleanup in #109016 missed that a service check needs to be done
against the abstract, not the implementation, so that own
authentication objects can be provided, instead of the abstract
implementation.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 910

  1. Garvin Hicking uploaded patch set 1 02/23/26, 15:05

  2. core-ci voted on patch set 1 V +1 02/23/26, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96590

  3. Benjamin Franzke commented on patch set 1 02/23/26, 15:44

    See > 92964: [BUGFIX] Ensure Sudo Mode is working again | https://review.typo3.org/c/Packages/TYPO3.CMS/+/92964
  4. Benjamin Franzke commented on patch set 1 CR +1 V +1 02/23/26, 15:45

    Reply

    Ah, i see, your's were the first one.
  5. Benjamin Franzke voted on patch set 1 CR 0 V 0 02/23/26, 15:46

  6. Garvin Hicking commented on patch set 1 02/23/26, 15:52

    Reply

    Bennys variant differs a bit, let's see
  7. Benni Mack voted on patch set 1 CR +1 V +1 02/24/26, 08:22

  8. Oliver Klee voted on patch set 1 CR +1 V +1 02/24/26, 08:26

  9. Garvin Hicking voted on patch set 1 CR +2 V +2 02/24/26, 08:39

  10. Garvin Hicking merged patch set 2 02/24/26, 08:39