Review main Abandoned

92964[BUGFIX] Ensure Sudo Mode is working again

Benni Mack CR 0 V -1 Easy +6 −26 updated 02/23/26, 19:23

Commit message

Due to a wrong check of AuthenticationService instead
of AbstractAuthenticationService, sudo mode did not work.

This has been solved via removing the broken code
parts in GeneralUtility::makeInstanceService().

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 3

Review log 68

  1. Benni Mack uploaded patch set 1 02/23/26, 15:08

  2. Benjamin Franzke voted on patch set 1 CR +1 V +1 02/23/26, 15:18

  3. core-ci voted on patch set 1 V -1 02/23/26, 15:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96591

  4. Benjamin Franzke commented on patch set 1 CR 0 V 0 02/23/26, 15:47

    (removing my vote for now, I didn't see/check the changes to GeneralUtility yet)
  5. core-ci commented on patch set 1 02/23/26, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96591

  6. Garvin Hicking commented on patch set 1 02/23/26, 15:53

    GeneralUtility.php:3110

    See my DM, I think this could be a BC for other services.
  7. Benni Mack commented on patch set 1 02/23/26, 16:41

    GeneralUtility.php:3110 Reply Unresolved

    another reason for me to really kick out any kind of "type hinting" to expect a value, because it is just wrong. I am sad that we now need to worry about these things due to adding typehints back then.
  8. Benni Mack abandoned the change 02/23/26, 19:23

    won't do it, this will be breaking