Review main Merged

92967[TASK] Update PHPStan to v2.1.40

Garvin Hicking CR +2 V +2 Easy +10 −10 updated 02/24/26, 11:52

Commit message

Updates PHPStan to the latest version 2.1.40.

Changes to new PHPStan findings are fixed to prevent new
baseline additions.

Executed commands:

> Build/Scripts/runTests.sh -s composer -- \
      require --dev phpstan/phpstan:^2.1.40
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Elias Häußler +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Elias Häußler +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 912

  1. Garvin Hicking uploaded patch set 1 02/24/26, 06:48

  2. Garvin Hicking updated the commit message in patch set 2 02/24/26, 06:48

  3. Anja Leichsenring voted on patch set 2 CR +1 V +1 02/24/26, 06:49

  4. Georg Ringer voted on patch set 2 CR +1 V +1 02/24/26, 06:51

  5. Elias Häußler voted on patch set 2 CR +1 V +1 02/24/26, 07:02

  6. core-ci voted on patch set 2 V -1 02/24/26, 07:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96672

  7. Garvin Hicking commented on patch set 2 02/24/26, 07:08

    That CI is the flakey playwright test. Restarting.
  8. core-ci voted on patch set 2 V +1 02/24/26, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96672

  9. core-ci voted on patch set 1 V -1 02/24/26, 07:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96671

  10. Oliver Klee voted on patch set 2 CR +1 V +1 02/24/26, 08:27

  11. Garvin Hicking voted on patch set 2 CR +2 V +2 02/24/26, 11:52

  12. Garvin Hicking merged patch set 3 02/24/26, 11:52