92971[FEATURE] Unify RateLimiterFactory as single entry point for rate limiting
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Torben Hansen +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Torben Hansen +1
- core-ci +1 CI
Issues 1
Files 17
- typo3/sysext/backend/Classes/Authentication/PasswordReset.php+2 −2
- typo3/sysext/backend/Classes/Middleware/BackendUserAuthenticator.php+4 −4
- typo3/sysext/backend/Configuration/Services.yaml+1 −2
- typo3/sysext/backend/Tests/Functional/Authentication/PasswordResetTest.php+9 −3
- typo3/sysext/core/Classes/RateLimiter/RateLimiterFactory.php+65 −20
- typo3/sysext/core/Classes/RateLimiter/RateLimiterFactoryInterface.phpnew+43 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −0
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+3 −0
- typo3/sysext/core/Configuration/Services.yaml+3 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-109080-UnifiedRateLimiterFactoryWithAdminOverrides.rst4new+168 −0
- typo3/sysext/core/Tests/Functional/RateLimiter/RateLimiterFactoryTest.php+84 −18
- typo3/sysext/extbase/Classes/Attribute/RateLimit.php+10 −0
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php2+12 −7
- typo3/sysext/extbase/Classes/Service/RateLimitService.phpdeleted+0 −71
- typo3/sysext/felogin/Classes/Controller/PasswordRecoveryController.php2+2 −2
- typo3/sysext/felogin/Configuration/Services.yaml+1 −2
- typo3/sysext/frontend/Classes/Middleware/FrontendUserAuthenticator.php+3 −3
Review log 1926
Show 1 earlier messages
-
Benni Mack uploaded patch set 1 02/24/26, 09:24
-
Benni Mack marked it ready for review 02/24/26, 09:26
-
core-ci voted on patch set 1 V -1 02/24/26, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96688
-
Georg Ringer commented on patch set 1 02/24/26, 09:49
-
Torben Hansen commented on patch set 1 02/24/26, 13:35
ActionController.php:108I get an exception here: `Cannot redeclare non-readonly property TYPO3\CMS\Extbase\Mvc\Controller\ActionController::$rateLimiterFactory as readonly TYPO3\CMS\FrontendLogin\Controller\PasswordRecoveryController::$rateLimiterFactory` I think we need a union type `RateLimiterFactoryInterface|RateLimiterFactory` here, because ext:felogin uses constructor injection and injects `RateLimiterFactoryInterface` for the property. -
Torben Hansen commented on patch set 1 02/24/26, 13:37
PasswordRecoveryController.php:58Must not be `readonly`. -
Benni Mack uploaded patch set 2
V -102/25/26, 22:52 -
core-ci voted on patch set 2 V -1 02/25/26, 23:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96859
-
Benni Mack uploaded patch set 3
V -102/26/26, 17:40 -
Benni Mack commented on patch set 3 02/26/26, 17:43
Feature-109080-UnifiedRateLimiterFactoryWithAdminOverrides.rst:46ReplyDone -
core-ci voted on patch set 3 V -1 02/26/26, 17:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96935
-
Benni Mack uploaded patch set 4
V -102/27/26, 19:20 -
Benni Mack commented on patch set 4 02/27/26, 19:20
ActionController.php:108ReplyDonePasswordRecoveryController.php:58ReplyDone -
core-ci voted on patch set 4 V -1 02/27/26, 19:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96992
-
Garvin Hicking commented on patch set 4 02/27/26, 21:11
Feature-109080-UnifiedRateLimiterFactoryWithAdminOverrides.rst:55We should have an example so that its clear the FQCN is needed (leading slash yes or no?), and the full method name like "indexAction" and not just "index". Also that everything is lowercases: Btw. How about replacing backslashes with dashes? Example reads a bit off and can have backslash-escaping issues. ```suggestion * :php:`extbase-<Controller>::<actionMethod>` — Extbase :php:`#[RateLimit]` actions. All lower-case. Example: `extbase-\\myvendor\\myextension\\classes\\controller\\mycontroller::createaction`. ``` -
Torben Hansen uploaded patch set 5
V -102/28/26, 13:45 -
Torben Hansen uploaded patch set 6 02/28/26, 13:46
-
Torben Hansen commented on patch set 6 02/28/26, 13:48
Feature-109080-UnifiedRateLimiterFactoryWithAdminOverrides.rst:55ReplyDone. I also replaced the two colons with one dash. -
Torben Hansen uploaded patch set 7 02/28/26, 13:56
-
core-ci voted on patch set 5 V -1 02/28/26, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97026
-
core-ci voted on patch set 7 V +1 02/28/26, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97028
-
core-ci voted on patch set 6 V -1 02/28/26, 14:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97027
-
Torben Hansen voted on patch set 7 CR +1 V +1 02/28/26, 14:12
-
Garvin Hicking voted on patch set 7 CR +1 V +1 02/28/26, 15:21
-
Benni Mack commented on patch set 7 CR +2 V +2 02/28/26, 15:27
Thank you for finishing this! -
Benni Mack merged patch set 8 02/28/26, 15:27
Feature-109080-UnifiedRateLimiterFactoryWithAdminOverrides.rst:46