Review main Merged

92974[TASK] Render workspaces dates via ICU message labels

Benjamin Franzke CR +2 V +2 Easy +18 −9 updated 09/03/26, 07:03

Commit message

GridDataService formatted the "last changed" timestamp and the stage
change comment timestamps server-side into display strings. The
workspaces JavaScript therefore received pre-rendered text that it
could neither re-format nor adapt to the viewer.

Both values are now transferred as ISO 8601 (ATOM) and rendered by
the Lit components through ICU message labels. The visible output is
unchanged, because the "medium" date and time presets are mapped back
to the configured SYS/ddmmyy and SYS/hhmm formats. The values are
machine readable now, which is the prerequisite for locale and time
zone aware rendering.

The AJAX payload field "lastChangedFormatted" is renamed to
"lastChanged", as it no longer carries a formatted value.

Two defects in the touched markup are fixed on the way: an empty
timestamp rendered "Invalid Date" instead of nothing, and the comment
badge was missing its closing tag.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Wouter Wolters +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 912

  1. Benjamin Franzke uploaded patch set 1 02/24/26, 10:07

  2. core-ci voted on patch set 1 V +1 02/24/26, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96697

  3. Benni Mack uploaded patch set 2 V +1 09/01/26, 13:32

  4. core-ci voted on patch set 2 V +1 09/01/26, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107493

  5. Benni Mack marked it ready for review 09/01/26, 14:57

  6. Georg Ringer voted on patch set 2 CR +1 V +1 09/02/26, 09:25

  7. Benni Mack uploaded patch set 3 CR +1 V +1 09/02/26, 16:25

  8. Wouter Wolters voted on patch set 3 CR +1 V +1 09/02/26, 16:31

  9. core-ci voted on patch set 3 V +1 09/02/26, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107655

  10. Benni Mack commented on patch set 3 CR +1 V +1 09/02/26, 20:04

    it works fine, but I had some struggles because I had to fetch the AJAX request with devtools "no-cache" while upgrading, due to the new label
  11. Benjamin Franzke commented on patch set 3 CR +2 V +2 09/03/26, 06:57

    Reply

    I see, this is unfortunate, indeed, but luckily only applies to dev context. We have a cache bust for label script-requests, but that uses the package cache identifier, which is currently not changing based on git-checkout: https://github.com/TYPO3/typo3/blob/beff9334a3c11e41e99acdc673fb0374786ea7ef/typo3/sysext/backend/Classes/Middleware/JavaScriptLabelImportMapEntryResolver.php#L37 Could be fixed by patches like > 84280: [WIP][TASK] Include Git revision in package cache identifier | https://review.typo3.org/c/Packages/TYPO3.CMS/+/84280 Resolving here as already discussed via slack.
  12. Benjamin Franzke merged patch set 4 09/03/26, 07:03