92974[TASK] Render workspaces dates via ICU message labels
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Wouter Wolters +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Wouter Wolters +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 6
- Build/Sources/TypeScript/workspaces/renderable/comment-view.ts+4 −2
- Build/Sources/TypeScript/workspaces/renderable/record-table.ts+2 −2
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+4 −3
- typo3/sysext/workspaces/Resources/Private/Language/locallang.xlf+6 −0
- typo3/sysext/workspaces/Resources/Public/JavaScript/renderable/comment-view.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/renderable/record-table.js+1 −1
Review log 912
-
Benjamin Franzke uploaded patch set 1 02/24/26, 10:07
-
core-ci voted on patch set 1 V +1 02/24/26, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96697
-
Benni Mack uploaded patch set 2
V +109/01/26, 13:32 -
core-ci voted on patch set 2 V +1 09/01/26, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107493
-
Benni Mack marked it ready for review 09/01/26, 14:57
-
Georg Ringer voted on patch set 2 CR +1 V +1 09/02/26, 09:25
-
Benni Mack uploaded patch set 3
CR +1V +109/02/26, 16:25 -
Wouter Wolters voted on patch set 3 CR +1 V +1 09/02/26, 16:31
-
core-ci voted on patch set 3 V +1 09/02/26, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107655
-
Benni Mack commented on patch set 3 CR +1 V +1 09/02/26, 20:04
it works fine, but I had some struggles because I had to fetch the AJAX request with devtools "no-cache" while upgrading, due to the new label -
Benjamin Franzke commented on patch set 3 CR +2 V +2 09/03/26, 06:57
Reply
I see, this is unfortunate, indeed, but luckily only applies to dev context. We have a cache bust for label script-requests, but that uses the package cache identifier, which is currently not changing based on git-checkout: https://github.com/TYPO3/typo3/blob/beff9334a3c11e41e99acdc673fb0374786ea7ef/typo3/sysext/backend/Classes/Middleware/JavaScriptLabelImportMapEntryResolver.php#L37 Could be fixed by patches like > 84280: [WIP][TASK] Include Git revision in package cache identifier | https://review.typo3.org/c/Packages/TYPO3.CMS/+/84280 Resolving here as already discussed via slack. -
Benjamin Franzke merged patch set 4 09/03/26, 07:03