Review main Merged

92979[TASK] Use moduleData and module subroutes in EXT:recycler

Benni Mack CR +2 V +2 Hard +128 −144 updated 02/24/26, 20:22

Commit message

The recycler extension stored user preferences (depthSelection,
tableSelection) manually via $beUser->uc['tx_recycler'] and routed
all AJAX calls through a single monolithic dispatch() endpoint.

This migrates to the standard moduleData system for persisting user
preferences and replaces the single AjaxRoutes.php entry with
individual module subroutes using the ajax flag.

Disclaimer: AI was assisting in restructuring
the code base.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 912

  1. Benni Mack uploaded patch set 1 02/24/26, 12:56

  2. core-ci voted on patch set 1 V +1 02/24/26, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96732

  3. Benni Mack marked it ready for review 02/24/26, 16:47

  4. Benni Mack updated the commit message in patch set 2 V +1 02/24/26, 16:48

  5. Benni Mack updated the commit message in patch set 3 02/24/26, 16:50

  6. core-ci voted on patch set 3 V +1 02/24/26, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96770

  7. core-ci voted on patch set 2 V +1 02/24/26, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96769

  8. Simon Schaufelberger commented on patch set 3 02/24/26, 17:40

    Since you are already working on it, can you also fix a bug that when I have "pages" selected and only change the depth, then everything is reset. When I go a level deeper and also have pages there, then I would expect to have pages still selected. If pages is not available, then "all".
  9. Simon Schaufelberger commented on patch set 3 02/24/26, 17:41

    Reply Unresolved

    Apart from that, I can confirm the patch is working correctly.
  10. Jochen Roth voted on patch set 3 CR +1 V +1 02/24/26, 17:44

  11. Georg Ringer voted on patch set 3 CR +2 V +2 02/24/26, 20:22

  12. Georg Ringer merged patch set 4 02/24/26, 20:22