92979[TASK] Use moduleData and module subroutes in EXT:recycler
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Jochen Roth +1
-
Verified V +2 Done
- Georg Ringer +2
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 7
- Build/Sources/TypeScript/recycler/recycler.ts+10 −9
- typo3/sysext/recycler/Classes/Controller/RecyclerAjaxController.php+79 −105
- typo3/sysext/recycler/Classes/Controller/RecyclerModuleController.php+3 −3
- typo3/sysext/recycler/Configuration/Backend/AjaxRoutes.phpdeleted+0 −13
- typo3/sysext/recycler/Configuration/Backend/Modules.php+25 −0
- typo3/sysext/recycler/Resources/Public/JavaScript/recycler.js+1 −1
- typo3/sysext/recycler/Tests/Functional/Controller/RecyclerAjaxControllerTest.php+10 −13
Review log 912
-
Benni Mack uploaded patch set 1 02/24/26, 12:56
-
core-ci voted on patch set 1 V +1 02/24/26, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96732
-
Benni Mack marked it ready for review 02/24/26, 16:47
-
Benni Mack updated the commit message in patch set 2
V +102/24/26, 16:48 -
Benni Mack updated the commit message in patch set 3 02/24/26, 16:50
-
core-ci voted on patch set 3 V +1 02/24/26, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96770
-
core-ci voted on patch set 2 V +1 02/24/26, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96769
-
Simon Schaufelberger commented on patch set 3 02/24/26, 17:40
Since you are already working on it, can you also fix a bug that when I have "pages" selected and only change the depth, then everything is reset. When I go a level deeper and also have pages there, then I would expect to have pages still selected. If pages is not available, then "all". -
Simon Schaufelberger commented on patch set 3 02/24/26, 17:41
Reply Unresolved
Apart from that, I can confirm the patch is working correctly. -
Jochen Roth voted on patch set 3 CR +1 V +1 02/24/26, 17:44
-
Georg Ringer voted on patch set 3 CR +2 V +2 02/24/26, 20:22
-
Georg Ringer merged patch set 4 02/24/26, 20:22