Review main Merged

92980[BUGFIX] Fix recycler pagination with multiple record types

Benni Mack CR +2 V +2 Normal +144 −2 updated 02/24/26, 19:42

Commit message

DeletedRecords was registered as a shared service, so all
GeneralUtility::makeInstance() calls within a single request
returned the same instance. Since loadData() and getTotalCount()
both append to internal arrays ($deletedRows, $table) without
resetting them, the second call accumulated state from the first.

This caused getTotalCount() to return wildly inflated values
(e.g. 53 instead of 9), making the paginator show phantom empty
pages and rendering records from prior calls on each page.

We fix this by marking DeletedRecords as a non-shared
service so each makeInstance() call returns a fresh instance.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Jochen Roth +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Jochen Roth +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1014

  1. Benni Mack uploaded patch set 1 02/24/26, 12:56

  2. Benni Mack rebased onto patch set 2 02/24/26, 12:56

  3. Benni Mack marked it ready for review 02/24/26, 12:56

  4. core-ci voted on patch set 1 V -1 02/24/26, 13:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96733

  5. core-ci voted on patch set 2 V -1 02/24/26, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96734

  6. Benni Mack commented on patch set 3 V -1 02/24/26, 14:14

    Published edit on patch set 2.
  7. core-ci voted on patch set 3 V -1 02/24/26, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96748

  8. Benni Mack uploaded patch set 4 V -1 02/24/26, 15:11

  9. core-ci voted on patch set 4 V +1 02/24/26, 15:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96760

  10. Jochen Roth voted on patch set 4 CR +1 V +1 02/24/26, 16:34

  11. Simon Schaufelberger commented on patch set 4 CR +1 V +1 02/24/26, 17:43

    Thank you so much for fixing this really annoying bug!
  12. Georg Ringer voted on patch set 4 CR +1 V +1 02/24/26, 19:35

  13. Benni Mack voted on patch set 4 CR +2 V +2 02/24/26, 19:42

  14. Benni Mack merged patch set 5 02/24/26, 19:42