92982[TASK] Introduce dedicated AJAX routes for cache clearing actions
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 18
- Build/Sources/TypeScript/backend/toolbar/clear-cache-menu.ts+12 −10
- Build/Sources/TypeScript/backend/clear-cache.ts+12 −4
- Build/Sources/TypeScript/backend/context-menu-actions.ts+12 −4
- typo3/sysext/backend/Classes/Backend/ToolbarItems/ClearCacheToolbarItem.php4+8 −8
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/PageProvider.php+1 −1
- typo3/sysext/backend/Classes/Controller/ClearCacheController.phpnew+98 −0
- typo3/sysext/backend/Classes/Controller/ClearPageCacheController.phpdeleted+0 −69
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+7 −4
- typo3/sysext/backend/Classes/Controller/RecordListController.php+4 −4
- typo3/sysext/backend/Configuration/Backend/AjaxRoutes.php+17 −6
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/ClearCacheToolbarItemDropDown.fluid.html+2 −2
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/ClearCacheToolbarItemSingle.fluid.html+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/toolbar/clear-cache-menu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/clear-cache.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/context-menu-actions.js+1 −1
- typo3/sysext/core/Resources/Private/Language/locallang_cache.xlf2new+54 −0
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+14 −14
- typo3/sysext/core/Tests/Acceptance/Application/Topbar/FlushCest.php+4 −4
Review log 1520
-
Benjamin Kott uploaded patch set 1 02/24/26, 14:10
-
Benjamin Kott uploaded patch set 2 02/24/26, 14:31
-
core-ci voted on patch set 2 V -1 02/24/26, 14:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96750
-
Benjamin Kott uploaded patch set 3
V -102/24/26, 15:00 -
core-ci voted on patch set 1 V -1 02/24/26, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96747
-
core-ci voted on patch set 3 V +1 02/24/26, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96758
-
Benjamin Kott uploaded patch set 4
V +102/24/26, 16:10 -
core-ci voted on patch set 4 V +1 02/24/26, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96766
-
Benjamin Kott rebased onto patch set 5
V +102/24/26, 22:10 -
core-ci voted on patch set 5 V +1 02/24/26, 22:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96781
-
Simon Schaufelberger commented on patch set 5 02/24/26, 22:59
-
Benjamin Franzke voted on patch set 5 CR +1 V +1 02/25/26, 05:41
-
Benjamin Kott commented on patch set 5 02/25/26, 06:47
locallang_cache.xlf:32ReplyI am not sure, this is a complete sentence intended to be placed here, and it ends with a ".". When there will be changes afterwards, i am fine - but i see no reason to remove them for now. -
Simon Schaufelberger voted on patch set 5 CR +1 V +1 02/25/26, 09:17
-
Benjamin Franzke voted on patch set 5 CR +2 V +2 02/25/26, 09:21
-
Benjamin Franzke merged patch set 6 02/25/26, 09:22
-
Benni Mack commented on patch set 6 02/25/26, 11:36
ClearCacheToolbarItem.php:90tbh, this change is a bit critical. Well, we have the cacheActions, and we have a PSR-14 Event right after that creation of this list. I know quite a few who hook into this and create their own "hrefs" now, and if we change the property from "href" / "link" to "endpoint" we could / should now at least document this (no talking about a breaking change) so extension authors dont have a hard time... please keep this is mind for next time. -
Simon Schaufelberger commented on patch set 6 02/25/26, 15:54
ClearCacheToolbarItem.php:90ReplyWill this break extensions like https://extensions.typo3.org/extension/flush_language_cache or not? This is the API that is uses: https://github.com/cobwebch/flush_language_cache/blob/master/Classes/EventListener/ClearCacheListener.php -
Benjamin Kott commented on patch set 6 02/26/26, 08:43
ClearCacheToolbarItem.php:90Replywill have a look and provide a followup -
Benjamin Kott commented on patch set 6 02/26/26, 12:35
ClearCacheToolbarItem.php:90ReplyPlease see: 93011: [BUGFIX] Migrate old href cache actions to endpoint | https://review.typo3.org/c/Packages/TYPO3.CMS/+/93011
locallang_cache.xlf:32