Review main Merged

92983[BUGFIX] Do not disable doc header buttons in FormEngine

Benjamin Kott CR +2 V +2 Easy +2 −26 updated 02/25/26, 10:56

Commit message

Removes `disableDocHeaderButtons()`, made obsolete by #109029.
The core handles form submissions manually and relies on button values
being present in the submitted data; disabling the buttons prevents
those values from being submitted, breaking the save workflow.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Bastien Lutz +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Bastien Lutz +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1317

  1. Benjamin Kott uploaded patch set 1 02/24/26, 14:50

  2. Bastien Lutz voted on patch set 1 CR +1 V +1 02/24/26, 14:53

  3. core-ci voted on patch set 1 V +1 02/24/26, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96754

  4. Oli Bartsch commented on patch set 1 V -1 02/24/26, 15:50

    I don't understand the relation here. #109029 did not introduce this method, #107681 did to prevent unintended triggering of the same actions multiple times. Why should we remove this safe-guard now, what did change? The commit message is really hard to understand this way.
  5. Bastien Lutz uploaded patch set 2 02/24/26, 15:54

    Copied Votes: * Code-Review+1 (copy condition: "**changekind:NO_CHANGE** OR is:MIN") * Verified+1, Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  6. Bastien Lutz commented on patch set 2 CR +1 V +1 02/24/26, 15:57

    Reply

    The issue currently is that with removing _doSave onChange=reload is broken as the data is not persisted anymore and the field cannot be modified anymore. Therefore the dokheaders are added again to let formengine persist the data.
  7. Benjamin Kott commented on patch set 2 02/24/26, 16:02

    Reply

    The persistence has changed, disabling the buttons prevents the submission of the values of the pressed submitters. This is obsolete, the submitters need to handle the prevention of the submissions themself. This workaround was implemented as the original implementation did not care about the submitters at all and disabled them.
  8. core-ci voted on patch set 2 V +1 02/24/26, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96762

  9. Benjamin Kott updated the commit message in patch set 3 CR +1 V +1 02/24/26, 16:23

  10. Benjamin Kott commented on patch set 3 02/24/26, 16:24

    Reply

    adjusted commit message to be better understandable.
  11. core-ci voted on patch set 3 V +1 02/24/26, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96768

  12. Benjamin Kott uploaded patch set 4 V +1 02/24/26, 22:13

  13. core-ci voted on patch set 4 V +1 02/24/26, 22:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96784

  14. Benjamin Franzke voted on patch set 4 CR +1 V +1 02/25/26, 05:48

  15. Bastien Lutz voted on patch set 4 CR +1 V +1 02/25/26, 09:37

  16. Benjamin Franzke commented on patch set 4 CR +2 V +2 02/25/26, 10:56

    Reply

    thanks.
  17. Benjamin Franzke merged patch set 5 02/25/26, 10:56