92984[FEATURE] Add PSR-14 event for redirect integrity checks
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Guido Schmechel +1
- Garvin Hicking +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Guido Schmechel +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-99491-PSR-14EventForRedirectIntegrityChecks.rst8new+115 −0
- typo3/sysext/redirects/Classes/Command/CheckIntegrityCommand.php+19 −0
- typo3/sysext/redirects/Classes/Event/RedirectIntegrityCheckEvent.phpnew+141 −0
- typo3/sysext/redirects/Classes/Service/IntegrityService.php2+36 −0
- typo3/sysext/redirects/Classes/Utility/RedirectConflict.php+1 −0
- typo3/sysext/redirects/Documentation/Events/Index.rst+7 −0
- typo3/sysext/redirects/Resources/Private/Language/locallang_db.xlf+3 −0
- typo3/sysext/redirects/Tests/Functional/Service/IntegrityServiceTest.php+51 −0
- typo3/sysext/redirects/Tests/Unit/Event/RedirectIntegrityCheckEventTest.phpnew+83 −0
Review log 2839
Show 914 earlier messages
-
Benni Mack uploaded patch set 1 02/24/26, 15:07
-
core-ci voted on patch set 1 V -1 02/24/26, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96759
-
core-ci commented on patch set 1 03/13/26, 15:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96759
-
Benni Mack marked it ready for review 03/13/26, 16:30
-
Garvin Hicking uploaded patch set 2
V -103/13/26, 21:25 -
core-ci voted on patch set 2 V +1 03/13/26, 21:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97923
-
Guido Schmechel commented on patch set 2 03/14/26, 13:02
Does it make sense for us to create a dummy enum value for users, something like RedirectConflict::INVALID_TARGET? Otherwise, we might end up with inconsistent results in the database, and TCA would also need to be updated constantly from integrators. Could we include this in the documentation as well? I’m also thinking about the filter on the redirect overview page. -
Garvin Hicking rebased onto patch set 3
V +103/30/26, 11:14 -
Stefan Bürk commented on patch set 3 03/30/26, 11:40
IntegrityService.php:97Event allows that integrity status is set to NULL but the database field is not nullable. I'd say we should use null coalsce falback to RedirectConflict::NO_CONFLICT here which is the TCA default. Other opinions ? -
core-ci voted on patch set 3 V -1 03/30/26, 11:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99046
-
Stefan Bürk commented on patch set 3 03/30/26, 11:45
IntegrityService.php:97ReplyForget it - missed the !== null condition nesting this part. -
Garvin Hicking rebased onto patch set 4
V -103/30/26, 13:30 -
Stefan Bürk uploaded patch set 5 03/30/26, 13:47
-
core-ci voted on patch set 4 V +1 03/30/26, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99066
-
Stefan Bürk uploaded patch set 6 03/30/26, 13:54
-
Stefan Bürk uploaded patch set 7 03/30/26, 13:56
-
core-ci voted on patch set 5 V +1 03/30/26, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99068
-
Stefan Bürk uploaded patch set 8 03/30/26, 14:04
-
core-ci voted on patch set 6 V +1 03/30/26, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99069
-
core-ci voted on patch set 7 V +1 03/30/26, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99070
-
core-ci voted on patch set 8 V -1 03/30/26, 14:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99071
-
core-ci voted on patch set 8 V +1 03/30/26, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99071
-
Stefan Bürk voted on patch set 8 CR +1 V +1 03/30/26, 14:26
-
Oliver Klee voted on patch set 8 V +1 03/30/26, 14:50
-
Guido Schmechel commented on patch set 8 03/30/26, 14:52
I check the code/functionality again later. For now, this is just feeback for the RST.Feature-99491-PSR-14EventForRedirectIntegrityChecks.rst:35DuplicateFeature-99491-PSR-14EventForRedirectIntegrityChecks.rst:39DuplicateFeature-99491-PSR-14EventForRedirectIntegrityChecks.rst:89Even though this works quickly and smoothly, maybe we should solve the example using the Linkservice and `resolve()` instead?Feature-99491-PSR-14EventForRedirectIntegrityChecks.rst:113alongside existing -
Benni Mack voted on patch set 8 CR +1 03/30/26, 15:22
-
Georg Ringer voted on patch set 8 CR +2 V +2 03/30/26, 15:37
-
Georg Ringer voted on patch set 8 CR +1 V +1 03/30/26, 15:37
-
Stefan Bürk commented on patch set 8 CR -1 03/30/26, 17:12
Taking care of the remarks for the rest file .... -
Stefan Bürk uploaded patch set 9
CR +1V +103/30/26, 17:30 -
Stefan Bürk commented on patch set 8 CR -1 V +1 03/30/26, 17:30
Feature-99491-PSR-14EventForRedirectIntegrityChecks.rst:35ReplyDoneFeature-99491-PSR-14EventForRedirectIntegrityChecks.rst:39ReplyDoneFeature-99491-PSR-14EventForRedirectIntegrityChecks.rst:89ReplyLet's keep that for now and polish the example after feature freeze with a advanced example.Feature-99491-PSR-14EventForRedirectIntegrityChecks.rst:113ReplyDone -
Stefan Bürk commented on patch set 9 03/30/26, 17:30
Reply
Done -
Stefan Bürk voted on patch set 9 CR +1 V +1 03/30/26, 17:30
-
Oliver Klee voted on patch set 9 V +1 03/30/26, 17:37
-
core-ci voted on patch set 9 V +1 03/30/26, 17:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99102
-
Guido Schmechel voted on patch set 9 CR +1 V +1 03/30/26, 18:10
-
Garvin Hicking voted on patch set 9 CR +1 V +1 03/30/26, 18:33
-
Stefan Bürk voted on patch set 9 CR +2 V +2 03/30/26, 18:40
-
Stefan Bürk merged patch set 10 03/30/26, 18:40