Review main Merged

92984[FEATURE] Add PSR-14 event for redirect integrity checks

Benni Mack CR +2 V +2 Hard +456 −0 updated 03/30/26, 18:40

Commit message

A new PSR-14 event `RedirectIntegrityCheckEvent` is dispatched
now for each redirect record during integrity checks, allowing
extensions to validate redirect targets and flag broken or
invalid redirects.

The existing integrity check only verifies whether redirect
sources conflict with existing page URLs (self-reference).
This event enables custom target validation, e.g. checking
whether t3://record links still resolve.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Guido Schmechel +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Guido Schmechel +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 2839

Show 914 earlier messages
  1. Benni Mack uploaded patch set 1 02/24/26, 15:07

  2. core-ci voted on patch set 1 V -1 02/24/26, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96759

  3. core-ci commented on patch set 1 03/13/26, 15:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96759

  4. Benni Mack marked it ready for review 03/13/26, 16:30

  5. Garvin Hicking uploaded patch set 2 V -1 03/13/26, 21:25

  6. core-ci voted on patch set 2 V +1 03/13/26, 21:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97923

  7. Guido Schmechel commented on patch set 2 03/14/26, 13:02

    Does it make sense for us to create a dummy enum value for users, something like RedirectConflict::INVALID_TARGET? Otherwise, we might end up with inconsistent results in the database, and TCA would also need to be updated constantly from integrators. Could we include this in the documentation as well? I’m also thinking about the filter on the redirect overview page.
  8. Garvin Hicking rebased onto patch set 3 V +1 03/30/26, 11:14

  9. Stefan Bürk commented on patch set 3 03/30/26, 11:40

    IntegrityService.php:97

    Event allows that integrity status is set to NULL but the database field is not nullable. I'd say we should use null coalsce falback to RedirectConflict::NO_CONFLICT here which is the TCA default. Other opinions ?
  10. core-ci voted on patch set 3 V -1 03/30/26, 11:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99046

  11. Stefan Bürk commented on patch set 3 03/30/26, 11:45

    IntegrityService.php:97 Reply

    Forget it - missed the !== null condition nesting this part.
  12. Garvin Hicking rebased onto patch set 4 V -1 03/30/26, 13:30

  13. Stefan Bürk uploaded patch set 5 03/30/26, 13:47

  14. core-ci voted on patch set 4 V +1 03/30/26, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99066

  1. Stefan Bürk uploaded patch set 6 03/30/26, 13:54

  2. Stefan Bürk uploaded patch set 7 03/30/26, 13:56

  3. core-ci voted on patch set 5 V +1 03/30/26, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99068

  4. Stefan Bürk uploaded patch set 8 03/30/26, 14:04

  5. core-ci voted on patch set 6 V +1 03/30/26, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99069

  6. core-ci voted on patch set 7 V +1 03/30/26, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99070

  7. core-ci voted on patch set 8 V -1 03/30/26, 14:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99071

  8. core-ci voted on patch set 8 V +1 03/30/26, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99071

  9. Stefan Bürk voted on patch set 8 CR +1 V +1 03/30/26, 14:26

  10. Oliver Klee voted on patch set 8 V +1 03/30/26, 14:50

  11. Guido Schmechel commented on patch set 8 03/30/26, 14:52

    I check the code/functionality again later. For now, this is just feeback for the RST.

    Feature-99491-PSR-14EventForRedirectIntegrityChecks.rst:35

    Duplicate

    Feature-99491-PSR-14EventForRedirectIntegrityChecks.rst:39

    Duplicate

    Feature-99491-PSR-14EventForRedirectIntegrityChecks.rst:89

    Even though this works quickly and smoothly, maybe we should solve the example using the Linkservice and `resolve()` instead?

    Feature-99491-PSR-14EventForRedirectIntegrityChecks.rst:113

    alongside existing
  12. Benni Mack voted on patch set 8 CR +1 03/30/26, 15:22

  13. Georg Ringer voted on patch set 8 CR +2 V +2 03/30/26, 15:37

  14. Georg Ringer voted on patch set 8 CR +1 V +1 03/30/26, 15:37

  15. Stefan Bürk commented on patch set 8 CR -1 03/30/26, 17:12

    Taking care of the remarks for the rest file ....
  16. Stefan Bürk uploaded patch set 9 CR +1 V +1 03/30/26, 17:30

  17. Stefan Bürk commented on patch set 8 CR -1 V +1 03/30/26, 17:30

    Feature-99491-PSR-14EventForRedirectIntegrityChecks.rst:35 Reply

    Done

    Feature-99491-PSR-14EventForRedirectIntegrityChecks.rst:39 Reply

    Done

    Feature-99491-PSR-14EventForRedirectIntegrityChecks.rst:89 Reply

    Let's keep that for now and polish the example after feature freeze with a advanced example.

    Feature-99491-PSR-14EventForRedirectIntegrityChecks.rst:113 Reply

    Done
  18. Stefan Bürk commented on patch set 9 03/30/26, 17:30

    Reply

    Done
  19. Stefan Bürk voted on patch set 9 CR +1 V +1 03/30/26, 17:30

  20. Oliver Klee voted on patch set 9 V +1 03/30/26, 17:37

  21. core-ci voted on patch set 9 V +1 03/30/26, 17:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99102

  22. Guido Schmechel voted on patch set 9 CR +1 V +1 03/30/26, 18:10

  23. Garvin Hicking voted on patch set 9 CR +1 V +1 03/30/26, 18:33

  24. Stefan Bürk voted on patch set 9 CR +2 V +2 03/30/26, 18:40

  25. Stefan Bürk merged patch set 10 03/30/26, 18:40