Review main Merged

92985[TASK] Centralize nonFields handling in DataHandler copy/localize methods

Benni Mack CR +2 V +2 Easy +26 −18 updated 03/10/26, 16:38

Commit message

Three methods (copyRecord, copyRecord_raw, localizeRecord) each
independently filtered $this->nonFields inside their field-processing
loops via in_array(). This is now centralized into a single
removeNonCopyableFields() method using array_diff_key().

For copyRecord_raw(), system field values (perms_*, t3ver_*) are
preserved before filtering and re-added after the loop so they
still reach insertNewCopyVersion() as before.

This is now possible due to the change of cc880c67

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Torben Hansen +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Benni Mack uploaded patch set 1 02/24/26, 19:02

  2. core-ci voted on patch set 1 V +1 02/24/26, 19:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96774

  3. Benni Mack updated the commit message in patch set 2 V +1 02/26/26, 13:51

  4. core-ci voted on patch set 2 V +1 02/26/26, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96924

  5. Torben Hansen voted on patch set 2 CR +1 V +1 03/07/26, 12:57

  6. Garvin Hicking voted on patch set 2 CR +1 V +1 03/09/26, 17:27

  7. Benni Mack voted on patch set 2 CR +2 V +2 03/10/26, 16:37

  8. Benni Mack merged patch set 3 03/10/26, 16:38