Review main Merged

92988[BUGFIX] Keep selection in filter when hard-deleting in recycler

Benni Mack CR +2 V +2 Easy +4 −3 updated 03/04/26, 09:46

Commit message

Also ensure selecting "All record types" is properly retained
by checking for existing options instead of using a falsy check.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Benni Mack uploaded patch set 1 02/25/26, 08:11

  2. core-ci voted on patch set 1 V +1 02/25/26, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96797

  3. Simon Schaufelberger voted on patch set 1 CR +1 V +1 02/25/26, 08:54

  4. Benjamin Franzke commented on patch set 1 V -1 02/25/26, 11:04

    After filtering (in my case "redirects") and deleting the filter stays intact :+1: but after seleting "all record types" again, the filter "jumps" back to the previously filtered value (in my case "redirects").
  5. Benni Mack uploaded patch set 2 CR +1 V +1 02/25/26, 17:59

  6. Benni Mack commented on patch set 2 02/25/26, 18:04

    Reply

    Thanks for the review. My || fallback accidentally made '' (the valid value for "All record types") fall through, should be solved now.
  7. core-ci voted on patch set 2 V +1 02/25/26, 18:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96845

  8. Simon Schaufelberger voted on patch set 2 CR +1 V +1 02/25/26, 23:56

  9. Christian Kuhn voted on patch set 2 CR +1 V +1 03/04/26, 08:43

  10. Christian Kuhn voted on patch set 2 CR +2 V +2 03/04/26, 09:28

  11. Christian Kuhn merged patch set 3 03/04/26, 09:46