92994[FEATURE] Support relative date formats in ext:form
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Garvin Hicking +1
-
Verified V +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 9
- Build/Sources/TypeScript/form/backend/form-editor/view-model.ts+26 −2
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-106681-SupportRelativeDateFormatsInDateRangeValidator.rstnew+84 −0
- typo3/sysext/form/Classes/EventListener/FormatDateRenderableBeforeRendering.php4+62 −0
- typo3/sysext/form/Classes/Mvc/Validation/DateRangeValidator.php2+53 −8
- typo3/sysext/form/Classes/Utility/DateRangeValidatorPatterns.phpnew+39 −0
- typo3/sysext/form/Resources/Private/Language/Database.xlf+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/view-model.js+1 −1
- typo3/sysext/form/Tests/Functional/Mvc/Validation/DateRangeValidatorTest.php+118 −0
- typo3/sysext/form/Tests/Unit/EventListener/FormatDateRenderableBeforeRenderingTest.phpnew+175 −0
Review log 1930
Show 35 earlier messages
-
Josua Vogel uploaded patch set 1 02/25/26, 13:00
-
core-ci voted on patch set 1 V -1 02/25/26, 13:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96821
-
Josua Vogel marked it work in progress 02/25/26, 13:33
-
Josua Vogel uploaded patch set 2
V -102/25/26, 14:20 -
core-ci voted on patch set 2 V -1 02/25/26, 14:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96825
-
Josua Vogel uploaded patch set 3
V -102/25/26, 14:42 -
Josua Vogel marked it ready for review 02/25/26, 14:46
-
Josua Vogel commented on patch set 3 02/25/26, 14:51
Please also take a look at the related ticket regarding an improvement to the UI. -
core-ci voted on patch set 3 V -1 02/25/26, 14:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96827
-
Josua Vogel rebased onto patch set 4
V -102/25/26, 14:59 -
core-ci voted on patch set 4 V -1 02/25/26, 15:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96829
-
core-ci voted on patch set 4 V +1 02/25/26, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96829
-
Josua Vogel updated the commit message in patch set 5
V +102/26/26, 10:28 -
core-ci voted on patch set 5 V +1 02/26/26, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96898
-
Josua Vogel rebased onto patch set 6
V +103/01/26, 12:33 -
core-ci voted on patch set 6 V +1 03/01/26, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97071
-
Garvin Hicking commented on patch set 6 03/01/26, 13:41
FormatDateRenderableBeforeRendering.php:26Why is the PHP and JS pattern different?FormatDateRenderableBeforeRendering.php:32I think we should harmonize this somehow, maybe pass it as data/lit arguments from PHP to JS to have it at a central place and not twice?DateRangeValidator.php:160More redundsncy here? -
Josua Vogel uploaded patch set 7
V +103/02/26, 12:52 -
Josua Vogel commented on patch set 7 03/02/26, 12:54
FormatDateRenderableBeforeRendering.php:26ReplyLegacy error - I fixed it. The JS pattern was the stricter one.FormatDateRenderableBeforeRendering.php:32ReplyFor now, I have only standardized the PHP part. I would tackle the JS part in the following PR, because I would have to rebuild it at this point anyway.DateRangeValidator.php:160ReplyFor now, I have only standardized the PHP part. I would tackle the JS part in the following PR, because I would have to rebuild it at this point anyway. -
Josua Vogel uploaded patch set 8 03/02/26, 12:59
-
core-ci voted on patch set 7 V +1 03/02/26, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97103
-
core-ci voted on patch set 8 V +1 03/02/26, 13:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97105
-
Garvin Hicking commented on patch set 8 CR +1 V +1 03/02/26, 13:39
Note: Currently the input date validator only shows "A date in format Y-m-d (...)" and misses the "or relative date" addition. The place for this is currently to small so the placeholder would not be shown. I can see that this will be addressed in the follow-up feature that revamps the GUI. I am voting under the assumption that we'll get the follow-up feature in as well. I think merging both patches would raise the complexity unneededly. -
Josua Vogel rebased onto patch set 9
CR +1V +103/02/26, 16:34 -
Josua Vogel updated the commit message in patch set 10 03/02/26, 16:36
-
core-ci voted on patch set 10 V +1 03/02/26, 16:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97128
-
core-ci voted on patch set 9 V +1 03/02/26, 17:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97126
-
Garvin Hicking voted on patch set 10 CR +1 V +1 03/02/26, 20:16
-
Georg Ringer voted on patch set 10 CR +2 V +2 03/02/26, 20:31
-
Georg Ringer merged patch set 11 03/02/26, 20:31