Review main Merged

92997[FEATURE] Include site configurations in import / export

Benjamin Kott CR +2 V +2 Expert +1576 −3 updated 03/27/26, 15:40

Commit message

Site configurations whose root page is part of an exported page tree
are now automatically embedded in the export file. On import the
configuration is restored with the remapped root page UID, skipped
when a site already exists for that page, and given a suffixed
identifier when the original name collides with an existing site.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 23

Show 3 more files

Review log 2336

Show 611 earlier messages
  1. Benjamin Kott uploaded patch set 1 02/25/26, 17:23

  2. core-ci voted on patch set 1 V -1 02/25/26, 18:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96841

  3. Benjamin Kott uploaded patch set 2 V -1 02/26/26, 07:10

  4. Benjamin Kott uploaded patch set 3 02/26/26, 07:17

  5. core-ci voted on patch set 2 V -1 02/26/26, 07:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96880

  6. core-ci voted on patch set 3 V -1 02/26/26, 07:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96881

  7. Benjamin Kott uploaded patch set 4 V -1 02/26/26, 08:39

  8. core-ci voted on patch set 4 V +1 02/26/26, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96889

  9. Benjamin Kott uploaded patch set 5 V +1 02/26/26, 09:45

  10. core-ci voted on patch set 5 V +1 02/26/26, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96895

  11. Benjamin Kott uploaded patch set 6 V +1 03/24/26, 11:37

  1. core-ci voted on patch set 6 V -1 03/24/26, 11:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98578

  2. Benjamin Kott uploaded patch set 7 V -1 03/24/26, 11:50

  3. core-ci voted on patch set 7 V +1 03/24/26, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98580

  4. Garvin Hicking commented on patch set 7 03/24/26, 13:51

    Dieclaimer: I have noy superficially looked at this. I think this can be a security issue for "advanced" editors that have export privileges and who could then access much more private data usually "hidden away" in the file system. I think this config export section would warrant to be available only for maintainers? Maybe even only gated to be available in CLI context?
  5. Benjamin Kott rebased onto patch set 8 V +1 03/24/26, 14:55

  6. core-ci voted on patch set 8 V +1 03/24/26, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98606

  7. Benjamin Kott rebased onto patch set 9 V +1 03/24/26, 23:11

  8. core-ci voted on patch set 9 V -1 03/24/26, 23:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98630

  9. Benjamin Kott rebased onto patch set 10 V -1 03/25/26, 07:35

  10. core-ci voted on patch set 10 V +1 03/25/26, 08:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98655

  11. Benni Mack commented on patch set 10 03/25/26, 20:42

    Reply

    sounds like this feature should only be enabled for admins then?
  12. Benjamin Franzke commented on patch set 10 03/26/26, 07:10

    Reply

    yes, and I *think* it should be configurable for admins, showing an always-disabled state for non admins.
  13. Benni Mack uploaded patch set 11 V +1 03/26/26, 16:34

  14. core-ci voted on patch set 11 V +1 03/26/26, 16:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98803

  15. Benni Mack commented on patch set 11 CR +1 V +1 03/26/26, 16:57

    Reply

    please re-check
  16. Georg Ringer voted on patch set 11 CR +1 V +1 03/26/26, 22:17

  17. Garvin Hicking commented on patch set 11 03/27/26, 07:16

    Reply

    If i read the code right on import a site config will be imported also as non-admin, if embedded? This would allow yaml injection from non-maintainers?
  18. Benjamin Kott uploaded patch set 12 CR +1 V +1 03/27/26, 14:16

  19. Benjamin Kott commented on patch set 12 03/27/26, 14:17

    Reply

    now covered
  20. core-ci voted on patch set 12 V +1 03/27/26, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98886

  21. Garvin Hicking uploaded patch set 13 V +1 03/27/26, 15:26

  22. Garvin Hicking commented on patch set 13 CR +1 V +1 03/27/26, 15:35

    Some edge cases that happen because my site configs contain %ENV% vars for rootPageId, which will not trigger an import. IMO beyond scope of this patch, rest seems to work just fine.
  23. core-ci voted on patch set 13 V +1 03/27/26, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98892

  24. Benni Mack voted on patch set 13 CR +2 V +2 03/27/26, 15:40

  25. Benni Mack merged patch set 14 03/27/26, 15:40