92997[FEATURE] Include site configurations in import / export
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 23
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-109340-IncludeSiteConfigurationsInImportExport.rstnew+46 −0
- typo3/sysext/impexp/Classes/Command/ExportCommand.php+7 −0
- typo3/sysext/impexp/Classes/Controller/ExportController.php+5 −0
- typo3/sysext/impexp/Classes/Controller/ImportController.php+11 −0
- typo3/sysext/impexp/Classes/Initialization/ImportContentOnPackageInitialization.php+5 −0
- typo3/sysext/impexp/Classes/Utility/ImportExportUtility.php+9 −0
- typo3/sysext/impexp/Classes/Export.php+31 −0
- typo3/sysext/impexp/Classes/Import.php+91 −0
- typo3/sysext/impexp/Resources/Private/Language/locallang.xlf+36 −0
- typo3/sysext/impexp/Resources/Private/Partials/Export/AdvancedOptions.fluid.html+24 −0
- typo3/sysext/impexp/Resources/Private/Partials/Import/MetaData.fluid.html+77 −0
- typo3/sysext/impexp/Resources/Private/Templates/Import.fluid.html+2 −2
- typo3/sysext/impexp/Tests/Functional/Command/ExportCommandTest.php+6 −0
- typo3/sysext/impexp/Tests/Functional/Export/IrreRecordsTest.php+2 −0
- typo3/sysext/impexp/Tests/Functional/Export/MultilingualPagesAndTtContentTest.php+4 −0
- typo3/sysext/impexp/Tests/Functional/Export/PagesAndTtContentTest.php+69 −0
- typo3/sysext/impexp/Tests/Functional/Export/PagesAndTtContentWithImagesTest.php+5 −0
- typo3/sysext/impexp/Tests/Functional/Export/PagesAndTtContentWithRelationsAndSoftrefsTest.php+4 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-site-config.xmlnew+619 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent-with-site-config.xmlnew+398 −0
Review log 2336
Show 611 earlier messages
-
Benjamin Kott uploaded patch set 1 02/25/26, 17:23
-
core-ci voted on patch set 1 V -1 02/25/26, 18:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96841
-
Benjamin Kott uploaded patch set 2
V -102/26/26, 07:10 -
Benjamin Kott uploaded patch set 3 02/26/26, 07:17
-
core-ci voted on patch set 2 V -1 02/26/26, 07:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96880
-
core-ci voted on patch set 3 V -1 02/26/26, 07:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96881
-
Benjamin Kott uploaded patch set 4
V -102/26/26, 08:39 -
core-ci voted on patch set 4 V +1 02/26/26, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96889
-
Benjamin Kott uploaded patch set 5
V +102/26/26, 09:45 -
core-ci voted on patch set 5 V +1 02/26/26, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96895
-
Benjamin Kott uploaded patch set 6
V +103/24/26, 11:37
-
core-ci voted on patch set 6 V -1 03/24/26, 11:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98578
-
Benjamin Kott uploaded patch set 7
V -103/24/26, 11:50 -
core-ci voted on patch set 7 V +1 03/24/26, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98580
-
Garvin Hicking commented on patch set 7 03/24/26, 13:51
Dieclaimer: I have noy superficially looked at this. I think this can be a security issue for "advanced" editors that have export privileges and who could then access much more private data usually "hidden away" in the file system. I think this config export section would warrant to be available only for maintainers? Maybe even only gated to be available in CLI context? -
Benjamin Kott rebased onto patch set 8
V +103/24/26, 14:55 -
core-ci voted on patch set 8 V +1 03/24/26, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98606
-
Benjamin Kott rebased onto patch set 9
V +103/24/26, 23:11 -
core-ci voted on patch set 9 V -1 03/24/26, 23:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98630
-
Benjamin Kott rebased onto patch set 10
V -103/25/26, 07:35 -
core-ci voted on patch set 10 V +1 03/25/26, 08:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98655
-
Benni Mack commented on patch set 10 03/25/26, 20:42
Reply
sounds like this feature should only be enabled for admins then? -
Benjamin Franzke commented on patch set 10 03/26/26, 07:10
Reply
yes, and I *think* it should be configurable for admins, showing an always-disabled state for non admins. -
Benni Mack uploaded patch set 11
V +103/26/26, 16:34 -
core-ci voted on patch set 11 V +1 03/26/26, 16:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98803
-
Benni Mack commented on patch set 11 CR +1 V +1 03/26/26, 16:57
Reply
please re-check -
Georg Ringer voted on patch set 11 CR +1 V +1 03/26/26, 22:17
-
Garvin Hicking commented on patch set 11 03/27/26, 07:16
Reply
If i read the code right on import a site config will be imported also as non-admin, if embedded? This would allow yaml injection from non-maintainers? -
Benjamin Kott uploaded patch set 12
CR +1V +103/27/26, 14:16 -
Benjamin Kott commented on patch set 12 03/27/26, 14:17
Reply
now covered -
core-ci voted on patch set 12 V +1 03/27/26, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98886
-
Garvin Hicking uploaded patch set 13
V +103/27/26, 15:26 -
Garvin Hicking commented on patch set 13 CR +1 V +1 03/27/26, 15:35
Some edge cases that happen because my site configs contain %ENV% vars for rootPageId, which will not trigger an import. IMO beyond scope of this patch, rest seems to work just fine. -
core-ci voted on patch set 13 V +1 03/27/26, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98892
-
Benni Mack voted on patch set 13 CR +2 V +2 03/27/26, 15:40
-
Benni Mack merged patch set 14 03/27/26, 15:40