Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
92998[TASK] Mark AbstractDomainObject as not-internal
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 9
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/98/92998/9 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/98/92998/9 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 1
Files 1
Review log 3443
Show 1418 earlier messages
-
Oliver Klee uploaded patch set 1 02/25/26, 18:12
-
core-ci voted on patch set 1 V +1 02/25/26, 18:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96846
-
Garvin Hicking commented on patch set 1 02/25/26, 20:09
Can we use @internal for that one declared method? While I agree we should lift this for the getUid/Pid methods, I think all other ones with underscores should receive an internal tag; otherwise we'll lock ourselves down here too much and limit refactoring an area that is in need of modernization....? -
Oliver Klee updated the commit message in patch set 2
V +102/25/26, 20:42 -
Oliver Klee commented on patch set 2 02/25/26, 20:43
Reply
Thanks, makes sense! Done. -
Oliver Klee uploaded patch set 3 02/25/26, 20:46
-
Oliver Klee marked it work in progress 02/25/26, 20:46
-
Oliver Klee uploaded patch set 4 02/25/26, 20:48
-
Oliver Klee marked it ready for review 02/25/26, 20:48
-
Oliver Klee commented on patch set 4 02/25/26, 20:49
Finally got my local git mixup sorted out. Sorry for the multiple pushes. -
core-ci voted on patch set 2 V +1 02/25/26, 21:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96853
-
core-ci voted on patch set 3 V +1 02/25/26, 21:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96854
-
core-ci voted on patch set 4 V +1 02/25/26, 21:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96855
-
Simon Schaufelberger voted on patch set 4 CR +1 V +1 02/26/26, 00:38
-
Garvin Hicking commented on patch set 4 02/26/26, 06:25
Reply
Did you intentionally omit the Interface "internal" changes? -
Oliver Klee commented on patch set 4 02/26/26, 07:47
Reply
Yes - and it seems I missed that we need the same changes there as well. New version coming up … -
Oliver Klee uploaded patch set 5
CR +1V +102/26/26, 07:48 -
Oliver Klee commented on patch set 4 02/26/26, 07:48
Reply
Done
-
core-ci voted on patch set 5 V +1 02/26/26, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96882
-
Garvin Hicking commented on patch set 5 02/26/26, 08:21
Just to note this here; Benni and me discussed this and we are a bit reluctant what this means for being able to "fix" Extbase and properly give it some maintenance love, and if we might restrict ourselves by lifting the "internal" veil. On the other hand we have to face the fact that the methods you mention are wildly used in the wild and we can't close our eyes to that fact that it's not really internal. Happy for any feedback/thoughts! -
Simon Schaufelberger voted on patch set 5 CR +1 V +1 02/26/26, 08:33
-
Simon Schaufelberger commented on patch set 5 02/26/26, 08:37
Reply
I even use the _ methods in some cases. -
Georg Ringer commented on patch set 5 CR +1 V +1 03/02/26, 19:24
I would only use that for main. it is for me only a code cleanup. -
Oliver Klee commented on patch set 5 03/03/26, 15:25
This sure cleans up the code. Also, it helps extension developers a lot. Without this change, I get lots of warnings like this in the PHPStan job at one of my extensions with TYPO3 13LTS: ------ ---------------------------------------------------------------------- 165 Call to method getUid() of internal class TYPO3\CMS\Extbase\DomainObject\AbstractDomainObject from outside its root namespace TYPO3. 🪪 method.internalClass 244 Call to method setPid() of internal class TYPO3\CMS\Extbase\DomainObject\AbstractDomainObject from outside its root namespace TYPO3. 🪪 method.internalClass So, a backport would really help extension developers avoid having a big PHPStan baseline. -
Sebastian Iffland voted on patch set 5 CR +1 03/19/26, 17:19
-
Benjamin Franzke commented on patch set 5 CR -1 03/19/26, 17:42
AbstractDomainObject.php:27This class basically states that it is an implementation detail between `AbstractEntity` and `AbstractValueObject` (nowadays this would be solved by an internal trait) and that *All Model domain objects* need to extend from either of this. Marking this class as non internal basically permits to circumvent this, which renders this comment invalid. I think this class should therefore be keep internal. Feel free though to mark the interface as non internal. Did you already have a look at this statement? -
Oliver Klee commented on patch set 5 03/22/26, 20:41
AbstractDomainObject.php:27ReplyIn a V13-compatible extension, I get this kind of warning from PHPStan for calls to `getUid()` on one of my models: ``` Call to method getUid() of internal class TYPO3\CMS\Extbase\DomainObject\AbstractDomainObject from outside its root namespace TYPO3. ``` This is what I'm trying to fix so I can have my extensions warning-free as much as possible. The way I read this PHPStan warning, the only way to really get rid of the warning is to either never call `getUid()` etc. (which isn't an option) or to make `AbstractDomainObject` non-internal (which is what I'm doing in this change). Would it help if I adapted the class comment in `AbstractDomainObject`? Or do you see any other way to fix this type of warning without ignoring/whitelisting the warning? -
Oliver Klee commented on patch set 5 03/31/26, 16:00
AbstractDomainObject.php:27Reply@ben@bnf.dev How can we continue here? -
Benjamin Franzke commented on patch set 5 04/01/26, 13:27
AbstractDomainObject.php:27ReplySorry, I missed you answer. Did you try to only mark the interface as non internal, as written above? > Feel free though to mark the interface as non internal. Shouldn't that work? -
Oliver Klee commented on patch set 5 04/01/26, 13:47
AbstractDomainObject.php:27Reply UnresolvedNo, this (most probably) won't help as PHPStan complain about using methods from the internal **class**, not about using methods from the internal **interface**: ``` Call to method getUid() of internal class TYPO3\CMS\Extbase\DomainObject\AbstractDomainObject from outside its root namespace TYPO3. ``` -
Oliver Klee wrote 04/14/26, 14:58
Topic set to extbase -
Oliver Klee marked it work in progress 04/14/26, 16:08
-
Oliver Klee uploaded patch set 6
CR +1V +104/14/26, 19:43 -
core-ci voted on patch set 6 V +1 04/14/26, 19:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100196
-
Oliver Klee uploaded patch set 7
V +104/16/26, 14:27 -
Oliver Klee marked it ready for review 04/16/26, 14:27
-
Oliver Klee commented on patch set 7 04/16/26, 14:28
This is the type of warning I'd like to avoid: https://github.com/oliverklee-de/onetimeaccount/actions/runs/24515596544/job/71658520585?pr=1225#step:8:26 -
core-ci voted on patch set 7 V +1 04/16/26, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100332
-
Oliver Klee marked it work in progress 04/16/26, 17:17
-
Oliver Klee rebased onto patch set 8
V +106/03/26, 10:30 -
core-ci voted on patch set 8 V +1 06/03/26, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102881
-
Oliver Klee rebased onto patch set 9
V +106/10/26, 15:06 -
core-ci voted on patch set 9 V +1 06/10/26, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103348