Review main Merged

93000[TASK] Deprecate FormEngine additionalHiddenFields

Benni Mack CR +2 V +2 Normal +80 −11 updated 03/02/26, 20:33

Commit message

The "additionalHiddenFields" result array key in FormEngine is a
legacy mechanism that stores hidden <input> HTML strings separately
from the main "html" key. This indirection is unnecessary since
elements can put hidden fields into "html" directly.

The following parts are now deprecated:
- "additionalHiddenFields" key in FormEngine result arrays
- FormResult::$hiddenFieldsHtml
- FormResultCollection::getHiddenFieldsHtml()

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Andreas Nedbal +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Nedbal +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 911

  1. Benni Mack uploaded patch set 1 02/25/26, 20:49

  2. core-ci voted on patch set 1 V +1 02/25/26, 21:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96856

  3. Benni Mack marked it ready for review 02/25/26, 22:55

  4. Simon Schaufelberger commented on patch set 1 02/25/26, 23:51

    Deprecation-109102-FormEngineAdditionalHiddenFields.rst:14

    why are 2 backticks used here? other code is only with one
  5. Benni Mack commented on patch set 2 V +1 03/02/26, 10:03

    Published edit on patch set 1.
  6. Benni Mack commented on patch set 2 03/02/26, 10:03

    Deprecation-109102-FormEngineAdditionalHiddenFields.rst:14 Reply

    Done
  7. core-ci voted on patch set 2 V +1 03/02/26, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97094

  8. Andreas Nedbal voted on patch set 2 CR +1 V +1 03/02/26, 16:11

  9. Anja Leichsenring voted on patch set 2 CR +1 V +1 03/02/26, 16:42

  10. Georg Ringer voted on patch set 2 CR +2 V +2 03/02/26, 20:33

  11. Georg Ringer merged patch set 3 03/02/26, 20:33