Review 13.4 Abandoned

93002[TASK] Allow phpdocumentor/reflection-docblock v6 and type-resolver v2

Benni Mack CR -2 V +1 Easy +5 −5 updated 04/21/26, 14:46

Commit message

We widen the composer constraints to support both current and next major
versions of phpdocumentor/reflection-docblock (^5.6.5 || ^6.0) and
phpdocumentor/type-resolver (^1.8.2 || ^2.0).

No code changes are needed as the API surface used
in extbase is identical across versions.

The actual raise will only happen when symfony 8 is supported.

The new versions still have PHP 7+ requirements, so there is
also nothing to fear.

Review

  • Code review CR -2
    • Benni Mack -2
    • Georg Ringer +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +1
    • Georg Ringer +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 912

  1. Benni Mack commented on patch set 1 02/25/26, 22:56

    Cherry Picked from branch main. The following files contain Git conflicts: * composer.json * composer.lock * typo3/sysext/extbase/composer.json
  2. Benni Mack commented on patch set 2 02/25/26, 22:56

    Published edit on patch set 1.
  3. Benni Mack uploaded patch set 3 02/25/26, 22:59

  4. core-ci voted on patch set 1 V -1 02/25/26, 23:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96860

  5. Benni Mack marked it ready for review 02/25/26, 23:01

  6. core-ci voted on patch set 2 V -1 02/25/26, 23:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96861

  7. core-ci voted on patch set 3 V +1 02/25/26, 23:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96862

  8. Simon Schaufelberger voted on patch set 3 CR +1 V +1 02/25/26, 23:42

  9. Oliver Klee voted on patch set 3 CR +1 V +1 02/26/26, 10:50

  10. Georg Ringer voted on patch set 3 CR +1 V +1 02/26/26, 11:41

  11. Benni Mack commented on patch set 3 CR -2 02/26/26, 12:05

    on hold for some time for v13
  12. Benni Mack abandoned the change 04/21/26, 14:46

    not going to happen