Review main Merged

93004[FEATURE] Add page-position-select component with insertion options

Tobias Wojtylak CR +2 V +2 Hard +408 −17 updated 03/23/26, 07:49

Commit message

Add a new component based on `page-browser` that allows selecting a page
and defining the insertion position as `inside` or `after`. When a page
node in the tree is selected, insertion options are shown, including
`Insert`, `After`, and `After` for all direct children. On first render,
the selected node is automatically scrolled into view via
`scrollNodeIntoViewIfNeeded`.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Benjamin Franzke +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Benjamin Franzke +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 10

Review log 2950

Show 1425 earlier messages
  1. Tobias Wojtylak uploaded patch set 1 02/26/26, 08:54

  2. core-ci voted on patch set 1 V +1 02/26/26, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96891

  3. Tobias Wojtylak uploaded patch set 2 V +1 02/27/26, 11:17

  4. core-ci voted on patch set 2 V +1 02/27/26, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96965

  5. Andreas Nedbal uploaded patch set 3 V +1 03/05/26, 09:54

  6. core-ci voted on patch set 3 V +1 03/05/26, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97399

  7. Tobias Wojtylak rebased onto patch set 4 V +1 03/06/26, 08:30

  8. core-ci voted on patch set 4 V -1 03/06/26, 09:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97469

  9. Tobias Wojtylak uploaded patch set 5 V -1 03/10/26, 07:24

  10. core-ci voted on patch set 5 V -1 03/10/26, 08:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97650

  11. Tobias Wojtylak uploaded patch set 6 V -1 03/12/26, 10:22

  12. Tobias Wojtylak uploaded patch set 7 03/12/26, 10:28

  13. core-ci voted on patch set 6 V -1 03/12/26, 10:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97808

  14. core-ci voted on patch set 7 V -1 03/12/26, 11:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97811

  15. Tobias Wojtylak uploaded patch set 8 V -1 03/12/26, 12:10

  16. core-ci voted on patch set 8 V -1 03/12/26, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97823

  17. Tobias Wojtylak uploaded patch set 9 V -1 03/12/26, 14:56

  18. core-ci voted on patch set 9 V -1 03/12/26, 15:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97838

  19. Tobias Wojtylak uploaded patch set 10 V -1 03/16/26, 15:52

  20. core-ci voted on patch set 10 V +1 03/16/26, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98028

  21. Andreas Nedbal commented on patch set 10 CR +1 V +1 03/16/26, 16:03

    This change is ready for review.
  22. Tobias Wojtylak uploaded patch set 11 CR +1 V +1 03/16/26, 16:44

  23. core-ci voted on patch set 11 V +1 03/16/26, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98037

  24. Georg Ringer commented on patch set 11 03/16/26, 18:26

    if it is a feature, please provide a feature.rst, thanks!
  25. Georg Ringer commented on patch set 11 03/16/26, 18:28

    locallang_core.xlf:603

    can we drop the "labels." prefix? all of those are labels. I agree not to touch the old ones but new ones can also use a better naming if that fits better
  1. Garvin Hicking commented on patch set 11 03/16/26, 21:35

    Subject needs to fit 72 chars
  2. Georg Ringer voted on patch set 11 CR -1 03/17/26, 05:52

  3. Tobias Wojtylak updated the commit message in patch set 12 CR -1 V +1 03/17/26, 11:20

  4. core-ci voted on patch set 12 V +1 03/17/26, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98088

  5. Tobias Wojtylak uploaded patch set 13 V +1 03/17/26, 12:57

  6. Tobias Wojtylak commented on patch set 13 03/17/26, 13:00

    Reply

    done

    Reply

    Done

    locallang_core.xlf:603 Reply

    Done
  7. core-ci voted on patch set 13 V +1 03/17/26, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98090

  8. Tobias Wojtylak uploaded patch set 14 V +1 03/17/26, 15:46

  9. core-ci voted on patch set 14 V +1 03/17/26, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98103

  10. Tobias Wojtylak uploaded patch set 15 V +1 03/18/26, 08:48

  11. Tobias Wojtylak uploaded patch set 16 03/18/26, 09:08

  12. core-ci voted on patch set 16 V +1 03/18/26, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98151

  13. core-ci voted on patch set 15 V -1 03/18/26, 09:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98148

  14. Tobias Wojtylak uploaded patch set 17 V +1 03/20/26, 08:22

  15. core-ci voted on patch set 17 V -1 03/20/26, 09:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98268

  16. core-ci voted on patch set 17 V +1 03/20/26, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98268

  17. Benjamin Kott rebased onto patch set 18 V +1 03/23/26, 06:29

  18. Benjamin Kott uploaded patch set 19 03/23/26, 06:38

  19. core-ci voted on patch set 18 V -1 03/23/26, 06:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98412

  20. Benjamin Kott voted on patch set 19 CR +1 V +1 03/23/26, 07:22

  21. Benjamin Franzke voted on patch set 19 CR +1 V +1 03/23/26, 07:22

  22. core-ci voted on patch set 18 V -1 03/23/26, 07:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98412

  23. core-ci voted on patch set 19 V +1 03/23/26, 07:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98416

  24. Andreas Nedbal voted on patch set 19 CR +2 V +2 03/23/26, 07:49

  25. Andreas Nedbal merged patch set 20 03/23/26, 07:49