93009[BUGFIX] Handle missing sys_file_reference in ExtendedFileUtility
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Georg Ringer +1
- Garvin Hicking +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Georg Ringer +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1115
-
Rico Sonntag uploaded patch set 1 02/26/26, 11:44
-
core-ci voted on patch set 1 V +1 02/26/26, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96905
-
Garvin Hicking commented on patch set 1 02/26/26, 19:38
Thanks for pushing a patch!ExtendedFileUtility.php:559when doing a native typehint (should be fine for a protected function) we can omit the phpdoc here. -
Rico Sonntag commented on patch set 1 03/02/26, 08:18
Note: This fix is also needed for the 13.4 branch. The previous backport attempt (change 93015) was abandoned due to an incorrect relation chain. A proper cherry-pick backport should be created after this change is merged. -
Rico Sonntag uploaded patch set 2
V +103/02/26, 08:31 -
Rico Sonntag commented on patch set 2 03/02/26, 08:34
Patch Set 2: Addressed review feedback - removed @return PHPDoc, native ?array typehint is sufficient. -
Rico Sonntag commented on patch set 2 03/02/26, 08:36
ExtendedFileUtility.phpReplyDone -
core-ci voted on patch set 2 V +1 03/02/26, 08:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97089
-
Garvin Hicking updated the commit message in patch set 3
V +103/02/26, 10:37 -
Garvin Hicking commented on patch set 3 CR +1 V +1 03/02/26, 10:40
I've added this to the commit body: ``` Releases: main, 13.4 ``` This allows us mergers to recognize for which versions a patch is meant. -
core-ci voted on patch set 3 V -1 03/02/26, 10:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97096
-
core-ci voted on patch set 3 V +1 03/02/26, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97096
-
Georg Ringer voted on patch set 3 CR +1 V +1 03/02/26, 19:33
-
Anja Leichsenring voted on patch set 3 CR +2 V +2 03/02/26, 19:34
-
Anja Leichsenring merged patch set 4 03/02/26, 19:34