Review main Merged

93011[BUGFIX] Migrate old href cache actions to endpoint

Benjamin Kott CR +2 V +2 Normal +159 −22 updated 04/08/26, 11:05

Commit message

The CacheAction array key `href` is deprecated in favor of `endpoint`.
The ClearCacheToolbarItem now automatically migrates `href` to `endpoint`
at runtime to maintain backward compatibility.

Additionally, the clear-cache toolbar now defaults to a success
notification when the endpoint response does not explicitly return
`success: false`, with fallback labels when `title` or `message` are
absent.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1113

  1. Benjamin Kott uploaded patch set 1 02/26/26, 12:34

  2. core-ci voted on patch set 1 V +1 02/26/26, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96907

  3. Simon Schaufelberger voted on patch set 1 CR +1 V +1 02/26/26, 13:17

  4. Benjamin Franzke commented on patch set 1 CR -1 02/26/26, 15:03

    ClearCacheToolbarItem.php:102

    I'm against this deprecation. It provides no value for the developers who have to change `href` to `endpoint`. If we provide zero technical improvement, we should support `href` and `endpoint`.
  5. Simon Schaufelberger commented on patch set 1 02/26/26, 15:10

    ClearCacheToolbarItem.php:102 Reply

    This patch is missing a reference to #109088 which is sadly already merged. Discussions should have happened there.
  6. Simon Schaufelberger commented on patch set 1 02/26/26, 15:12

    ClearCacheToolbarItem.php:102 Reply

    Right now all custom clear cache actions are broken because they use "href". See the discussion here https://review.typo3.org/c/Packages/TYPO3.CMS/+/92982
  7. Benjamin Franzke commented on patch set 1 02/27/26, 08:15

    ClearCacheToolbarItem.php:102 Reply

    I know, which is why Benji is trying to fix the breakage that was caused by that merge. I simply don't wont to deprecate, but (silently) migrate, without deprecation. I'll adapt the patch.
  8. Benjamin Kott uploaded patch set 2 CR +1 V +1 04/08/26, 08:52

  9. Benjamin Franzke commented on patch set 2 CR +1 V +1 04/08/26, 08:53

    ClearCacheToolbarItem.php:102 Reply

    Fine by me
  10. core-ci voted on patch set 2 V +1 04/08/26, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99747

  11. Simon Schaufelberger voted on patch set 2 CR +1 V +1 04/08/26, 09:50

  12. Benjamin Kott voted on patch set 2 CR +2 V +2 04/08/26, 11:05

  13. Benjamin Kott merged patch set 3 04/08/26, 11:05