93013[BUGFIX] Add missing error handling for Redis commands in RedisBackend
Commit message
Review
-
Code review CR 0
-
Verified V -1
- core-ci -1 CI
Issues 1
Files 2
Review log 1825
-
Rico Sonntag uploaded patch set 1 02/26/26, 12:37
-
core-ci voted on patch set 1 V -1 02/26/26, 13:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96909
-
Markus Klein commented on patch set 1 02/26/26, 13:57
RedisBackend.php:328Let's move this into a dedicated log function, so we do not repeat the getLastError call all over the place. -
Rico Sonntag commented on patch set 1 03/02/26, 08:18
Note: This fix is also needed for the 13.4 branch. The previous backport attempt (change 93014) was abandoned due to an incorrect relation chain. A proper cherry-pick backport should be created after this change is merged. -
Rico Sonntag uploaded patch set 2
V -103/02/26, 08:31 -
Rico Sonntag commented on patch set 2 03/02/26, 08:34
Patch Set 2: Addressed review feedback - extracted logRedisCommandFailure() helper method, simplified if (!empty($existingTags)) to if ($existingTags). Also fixed php_unit_test_case_static_method_calls CGL warning (self::once() -> $this->once()). -
Rico Sonntag commented on patch set 2 03/02/26, 08:36
RedisBackend.phpReplyDoneRedisBackend.phpReplyDone -
core-ci voted on patch set 2 V +1 03/02/26, 08:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97088
-
Markus Klein updated the commit message in patch set 3
V +103/02/26, 09:44 -
core-ci voted on patch set 3 V +1 03/02/26, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97092
-
Markus Klein commented on patch set 3 03/03/26, 14:46
thanks for the update, just minor remarks. But should we do the same for the RedisSessionBackend?RedisBackend.php:480protected is better for extensibilityRedisBackend.php:482we can use placeholders here for readability: https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/Logging/Logger/Index.html#use-placeholders -
Rico Sonntag uploaded patch set 4
V +103/03/26, 18:04 -
Rico Sonntag uploaded patch set 5 03/03/26, 18:05
-
Rico Sonntag commented on patch set 5 03/03/26, 18:05
Reply
Good point. The RedisSessionBackend uses different Redis methods (get, set, del, scan, mGet) and would benefit from similar error handling. I'll address that in a separate change.RedisBackend.phpReplyDoneRedisBackend.phpReplyDone -
core-ci voted on patch set 4 V -1 03/03/26, 18:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97207
-
core-ci voted on patch set 5 V -1 03/03/26, 18:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97208
-
Rico Sonntag uploaded patch set 6
V -103/03/26, 19:30 -
Rico Sonntag commented on patch set 6 03/03/26, 19:46
RedisSessionBackend follow-up created: https://review.typo3.org/c/Packages/TYPO3.CMS/+/93048 -
core-ci voted on patch set 6 V +1 03/03/26, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97217
-
Markus Klein voted on patch set 6 CR +1 V +1 03/09/26, 08:52
-
Sven Liebert voted on patch set 6 CR +1 V +1 03/10/26, 14:13
-
Benni Mack updated the commit message in patch set 7
CR +1V +104/22/26, 06:41 -
core-ci voted on patch set 7 V -1 04/22/26, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100761
-
Benni Mack abandoned the change 10/02/26, 09:37
-
Markus Klein commented on patch set 7 10/02/26, 11:02
Unresolved
@benni@typo3.org Abandon is wrong IMO. This patch is about cache-backend, the other one about session-backend
RedisBackend.php:266