93016[FEATURE] Translate defaultValue of form elements
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Garvin Hicking +1
-
Verified V +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 2
Files 8
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-97637-TranslateDefaultValueOfFormElements.rst6new+95 −0
- typo3/sysext/form/Classes/EventListener/TranslateDefaultValueBeforeRendering.php2new+65 −0
- typo3/sysext/form/Classes/Service/TranslationService.php+2 −0
- typo3/sysext/form/Documentation/I/Concepts/FrontendRendering/Index.rst+8 −0
- typo3/sysext/form/Tests/Functional/Fixtures/Extensions/form_labels/Resources/Private/Language/locallang_form.xlf+3 −0
- typo3/sysext/form/Tests/Functional/Fixtures/Extensions/form_labels/Resources/Private/Language/locallang_text.xlf+9 −0
- typo3/sysext/form/Tests/Functional/Service/TranslationServiceTest.php2+205 −36
- typo3/sysext/form/Tests/Unit/EventListener/TranslateDefaultValueBeforeRenderingTest.phpnew+141 −0
Review log 1825
-
Josua Vogel uploaded patch set 1 02/26/26, 14:45
-
Josua Vogel marked it work in progress 02/26/26, 14:45
-
core-ci voted on patch set 1 V +1 02/26/26, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96929
-
Josua Vogel uploaded patch set 2
V +103/03/26, 08:38 -
Josua Vogel marked it ready for review 03/03/26, 08:38
-
core-ci voted on patch set 2 V -1 03/03/26, 08:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97158
-
Josua Vogel commented on patch set 3
V -103/03/26, 09:05Published edit on patch set 2. -
core-ci voted on patch set 3 V +1 03/03/26, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97163
-
Josua Vogel updated the commit message in patch set 4
V +103/03/26, 12:49 -
core-ci voted on patch set 4 V +1 03/03/26, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97177
-
Josua Vogel rebased onto patch set 5
V +103/10/26, 15:03 -
core-ci voted on patch set 5 V +1 03/10/26, 15:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97706
-
Garvin Hicking commented on patch set 5 03/14/26, 16:45
Feature-97637-TranslateDefaultValueOfFormElements.rst:54It would help to have an example that actually "translates", like: identifier: bestDish label: 'Best dish?' defaultValue: 'Hamburger' and then have an example for `de.locallang.xlf` (not just locallang.xlf) with: identifier: bestDish label: 'Lieblingsgericht' defaultValue: 'Kartoffel'TranslateDefaultValueBeforeRendering.php:28Whole class can be readonly?TranslationServiceTest.php:548If we try, we can fit Hamlet in here! -
Garvin Hicking commented on patch set 5 03/14/26, 16:48
Feature-97637-TranslateDefaultValueOfFormElements.rst:53I think the form definition example above should also hold the `contact-form` identifier to understand how this mapping comes across -
Garvin Hicking voted on patch set 5 V +1 03/14/26, 17:04
-
Josua Vogel uploaded patch set 6
V +103/16/26, 14:49 -
Josua Vogel commented on patch set 6 03/16/26, 14:50
Feature-97637-TranslateDefaultValueOfFormElements.rst:53ReplyDoneFeature-97637-TranslateDefaultValueOfFormElements.rst:54ReplyDoneTranslateDefaultValueBeforeRendering.php:28ReplyDoneTranslationServiceTest.php:548ReplyDone -
core-ci voted on patch set 6 V +1 03/16/26, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98023
-
Garvin Hicking commented on patch set 6 03/16/26, 17:44
Feature-97637-TranslateDefaultValueOfFormElements.rst:57Why is "/Form/" gone here? The yaml references the subdir...? -
Josua Vogel commented on patch set 7
V +103/16/26, 19:21Published edit on patch set 6. -
Josua Vogel commented on patch set 7 03/16/26, 19:22
Feature-97637-TranslateDefaultValueOfFormElements.rst:57ReplyIncorrectly adjusted 😄 -
core-ci voted on patch set 7 V +1 03/16/26, 19:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98044
-
Garvin Hicking voted on patch set 7 CR +1 V +1 03/16/26, 20:17
-
Georg Ringer voted on patch set 7 CR +2 V +2 03/17/26, 05:51
-
Georg Ringer merged patch set 8 03/17/26, 05:51