93019[TASK] Replace jQuery in EXT:form with VanillaJS - Part 1
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Josua Vogel +1
-
Verified V +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Josua Vogel +1
- core-ci +1 CI
Issues 1
Files 14
- Build/Sources/TypeScript/form/backend/form-editor/core.ts+38 −38
- Build/Sources/TypeScript/form/backend/form-editor/helper.ts+1 −1
- Build/Sources/TypeScript/form/backend/form-editor/inspector-component.ts+19 −19
- Build/Sources/TypeScript/form/backend/form-editor/modals-component.ts+4 −4
- Build/Sources/TypeScript/form/backend/form-editor/stage-component.ts+24 −22
- Build/Sources/TypeScript/form/backend/form-editor/view-model.ts+13 −12
- Build/Sources/TypeScript/form/backend/form-editor.ts2+8 −8
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/core.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/helper.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/inspector-component.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/modals-component.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/stage-component.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/view-model.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor.js+2 −2
Review log 1518
-
Benni Mack uploaded patch set 1 02/26/26, 21:24
-
core-ci voted on patch set 1 V +1 02/26/26, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96939
-
Josua Vogel commented on patch set 1 02/27/26, 07:39
Unfortunately, an error message appears immediately when opening the form editor 😞 -
Josua Vogel commented on patch set 1 02/27/26, 07:39
Reply
unresolve -
Benjamin Franzke commented on patch set 1 CR -1 02/27/26, 08:13
form-editor.ts:109Please be aware that `$.type()` is extremely hard to migrate. Yes, `null` is an object, but also `Array`, see: vanilla js: ``` typeof [] 'object' ``` vs jQuery: ``` $.type([]) 'array' ``` So `$.type(foo) === 'object'` needs to be migrated to: ``` typeof foo === 'object' && foo !== null && !Array.isArray(foo) ``` -
Benni Mack commented on patch set 1 02/27/26, 08:39
sorry, was late yesterday, on it now again... this is obviously WIP. -
Benni Mack marked it work in progress 02/27/26, 08:39
-
Benni Mack uploaded patch set 2
CR -1V +102/27/26, 12:20 -
core-ci voted on patch set 2 V +1 02/27/26, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96970
-
Benni Mack marked it ready for review 02/27/26, 16:02
-
Josua Vogel voted on patch set 2 CR +1 V +1 02/28/26, 17:19
-
Benni Mack uploaded patch set 3
CR +1V +103/04/26, 07:57 -
core-ci voted on patch set 3 V +1 03/04/26, 08:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97268
-
Josua Vogel voted on patch set 3 CR +1 V +1 03/04/26, 08:25
-
Benjamin Franzke commented on patch set 3 CR +1 V +1 03/04/26, 08:55
minor nitpick: `!isNaN(…)` but can be merged anyway if you ask me.form-editor.ts:109ReplyDone -
Benni Mack voted on patch set 3 CR +2 V +2 03/04/26, 09:07
-
Benni Mack merged patch set 4 03/04/26, 09:07