Review main Merged

93019[TASK] Replace jQuery in EXT:form with VanillaJS - Part 1

Benni Mack CR +2 V +2 Normal +115 −112 updated 03/04/26, 09:07

Commit message

This tackles the easy parts:

- $.type replaced by native "typeof" check (except for objects)
- $.type(xyz) === array replaced by "Array.isArray()"
- $.isNumeric replaced by "isNaN(Number("

The config merge in helper.ts might be removed in a further iteration.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 1518

  1. Benni Mack uploaded patch set 1 02/26/26, 21:24

  2. core-ci voted on patch set 1 V +1 02/26/26, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96939

  3. Josua Vogel commented on patch set 1 02/27/26, 07:39

    Unfortunately, an error message appears immediately when opening the form editor 😞
  4. Josua Vogel commented on patch set 1 02/27/26, 07:39

    Reply

    unresolve
  5. Benjamin Franzke commented on patch set 1 CR -1 02/27/26, 08:13

    form-editor.ts:109

    Please be aware that `$.type()` is extremely hard to migrate. Yes, `null` is an object, but also `Array`, see: vanilla js: ``` typeof [] 'object' ``` vs jQuery: ``` $.type([]) 'array' ``` So `$.type(foo) === 'object'` needs to be migrated to: ``` typeof foo === 'object' && foo !== null && !Array.isArray(foo) ```
  6. Benni Mack commented on patch set 1 02/27/26, 08:39

    sorry, was late yesterday, on it now again... this is obviously WIP.
  7. Benni Mack marked it work in progress 02/27/26, 08:39

  8. Benni Mack uploaded patch set 2 CR -1 V +1 02/27/26, 12:20

  9. Benni Mack commented on patch set 2 02/27/26, 12:25

    Reply

    Done

    Reply

    Done
  10. core-ci voted on patch set 2 V +1 02/27/26, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96970

  11. Benni Mack marked it ready for review 02/27/26, 16:02

  12. Josua Vogel voted on patch set 2 CR +1 V +1 02/28/26, 17:19

  13. Benni Mack uploaded patch set 3 CR +1 V +1 03/04/26, 07:57

  14. core-ci voted on patch set 3 V +1 03/04/26, 08:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97268

  15. Josua Vogel voted on patch set 3 CR +1 V +1 03/04/26, 08:25

  16. Benjamin Franzke commented on patch set 3 CR +1 V +1 03/04/26, 08:55

    minor nitpick: `!isNaN(…)` but can be merged anyway if you ask me.

    form-editor.ts:109 Reply

    Done
  17. Benni Mack voted on patch set 3 CR +2 V +2 03/04/26, 09:07

  18. Benni Mack merged patch set 4 03/04/26, 09:07