Review 13.4 Merged

93020[BUGFIX] Apply CSP headers to default error responses

Oliver Hader CR +2 V +2 Normal +161 −33 updated 02/27/26, 07:45

Commit message

Error responses from ErrorController::handleDefaultError()
bypass the ContentSecurityPolicyHeaders middleware since it
sits deeper in the stack. Centralize CSP application logic
in ContentSecurityPolicyHeaders via a new applyToResponse()
method and call it from ErrorController for default error
responses.

Configured error handlers (e.g. PageContentErrorHandler)
already apply their own CSP headers via subrequest, so only
the fallback handleDefaultError() path needs wrapping.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 9

Review log 34

  1. Oliver Hader uploaded patch set 1 02/27/26, 07:15

  2. core-ci voted on patch set 1 V +1 02/27/26, 07:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96952

  3. Oliver Hader voted on patch set 1 CR +2 V +2 02/27/26, 07:44

  4. Oliver Hader merged patch set 2 02/27/26, 07:45