93021[TASK] Mark shortcut as required if shortcut_mode=0
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 8
- Build/Sources/TypeScript/backend/form-engine/field-wizard/shortcut-validation.ts4new+61 −0
- typo3/sysext/backend/Classes/Form/Element/GroupElement.php+4 −0
- typo3/sysext/backend/Classes/Form/FieldWizard/ShortcutValidation.phpnew+38 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaShortcut.php4new+48 −0
- typo3/sysext/backend/Classes/Form/NodeFactory.php2+1 −0
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/field-wizard/shortcut-validation.jsnew+13 −0
- typo3/sysext/core/Configuration/TCA/pages.php+5 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+5 −0
Review log 3347
Show 1322 earlier messages
-
Bastien Lutz uploaded patch set 1 02/27/26, 08:10
-
core-ci voted on patch set 1 V -1 02/27/26, 08:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96955
-
Bastien Lutz uploaded patch set 2
V -102/27/26, 13:28 -
core-ci voted on patch set 2 V -1 02/27/26, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96972
-
Bastien Lutz uploaded patch set 3
V -102/27/26, 14:52 -
core-ci voted on patch set 3 V -1 02/27/26, 15:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96975
-
Bastien Lutz uploaded patch set 4
V -103/02/26, 12:37 -
core-ci voted on patch set 4 V +1 03/02/26, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97101
-
Bastien Lutz uploaded patch set 5
V +103/02/26, 13:31 -
core-ci voted on patch set 5 V -1 03/02/26, 13:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97110
-
Bastien Lutz uploaded patch set 6
V -103/02/26, 13:50 -
core-ci voted on patch set 6 V +1 03/02/26, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97114
-
Bastien Lutz marked it ready for review 03/02/26, 14:21
-
Georg Ringer commented on patch set 6 CR -1 03/02/26, 17:35
testing this in single table mode with column "shortcut" only will trigger a failed ajax response with exception message --- Variable "shortcut_mode" is not valid around position 1 for expression `shortcut_mode == "0"`. --- -
Bastien Lutz rebased onto patch set 7
CR -1V +103/09/26, 08:51The following files contain Git conflicts: * typo3/sysext/backend/Configuration/Backend/Routes.php -
core-ci voted on patch set 7 V -1 03/09/26, 09:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97589
-
Bastien Lutz uploaded patch set 8
V -103/09/26, 09:41 -
core-ci voted on patch set 8 V +1 03/09/26, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97590
-
Bastien Lutz uploaded patch set 9
V +103/13/26, 15:46 -
core-ci voted on patch set 9 V +1 03/13/26, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97913
-
Bastien Lutz marked it ready for review 03/16/26, 13:02
-
Simon Schaufelberger commented on patch set 9 03/16/26, 13:06
NodeFactory.php:129please sort it alphabetically
-
Bastien Lutz uploaded patch set 10
V +103/16/26, 15:03 -
Bastien Lutz commented on patch set 10 03/16/26, 15:03
NodeFactory.php:129ReplyDone -
core-ci voted on patch set 10 V +1 03/16/26, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98024
-
Andreas Nedbal voted on patch set 10 CR +1 V +1 03/16/26, 15:50
-
Oli Bartsch commented on patch set 10 03/17/26, 11:44
shortcut-validation.ts:40Why not just call `this.apply()` here?shortcut-validation.ts:47Seems as this could trigger exceptions in case shortcut is null. Even the argument is not nullable, calling code currently does not check the element, same for form.TcaShortcut.php:41Could still be undefined, right? -
Bastien Lutz uploaded patch set 11
CR +1V +103/18/26, 12:08 -
Bastien Lutz commented on patch set 11 03/18/26, 12:08
shortcut-validation.ts:40ReplyDoneshortcut-validation.ts:47ReplyDoneTcaShortcut.php:41ReplyDone -
core-ci voted on patch set 11 V -1 03/18/26, 13:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98177
-
core-ci voted on patch set 11 V +1 03/18/26, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98177
-
Tobias Wojtylak commented on patch set 11 03/18/26, 14:14
TcaShortcut.php:41How about simplifying this if ```suggestion $shortcutMode = $result['databaseRow']['shortcut_mode'] ?? null; if ((int)($shortcutMode[0] ?? $shortcutMode) === PageRepository::SHORTCUT_MODE_NONE) { ``` -
Bastien Lutz commented on patch set 11 03/19/26, 14:52
TcaShortcut.php:41Replythis is needed as we need to check if the field is set, if the field is an array value check the first item. If not check the value directly. (Usually shortcut_mode is an array value as it is configured as type select) -
Simon Schaufelberger wrote 03/19/26, 16:36
Removed cc Simon Schaufelberger. -
Bastien Lutz uploaded patch set 12
V +103/20/26, 08:58 -
core-ci voted on patch set 12 V +1 03/20/26, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98277
-
Tobias Wojtylak voted on patch set 12 CR +1 03/20/26, 11:24
-
André Buchmann voted on patch set 12 CR +1 V +1 04/19/26, 20:32
-
Simon Schaufelberger voted on patch set 12 CR +1 V +1 06/29/26, 12:03
-
Benjamin Franzke voted on patch set 12 CR +2 V +2 06/29/26, 12:29
-
Benjamin Franzke commented on patch set 12 CR +1 V +1 06/29/26, 12:39
Rebased to edit commit message (we do now also want to target 14.3) and to rerun CI (the run in 3 months old). Hope we get quick revotes. -
Benjamin Franzke commented on patch set 13
CR +1V +106/29/26, 12:39Published edit on patch set 12. -
Benjamin Franzke rebased onto patch set 14 06/29/26, 12:39
-
core-ci voted on patch set 14 V +1 06/29/26, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104027
-
Simon Schaufelberger voted on patch set 14 CR +1 V +1 06/29/26, 13:17
-
Benjamin Franzke voted on patch set 14 CR +2 V +2 06/30/26, 07:44
-
Benjamin Franzke merged patch set 15 06/30/26, 07:44