93027[TASK] phpstan: do not treatPhpDocTypesAsCertain
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 7
- Build/phpstan/src/Rules/Classes/UnneededInstanceOfRule.php+3 −7
- Build/phpstan/phpstan-baseline.neon+64 −190
- Build/phpstan/phpstan.neon+6 −5
- typo3/sysext/backend/Classes/Backend/Avatar/Avatar.php+0 −1
- typo3/sysext/backend/Classes/Form/Utility/FormEngineUtility.php+1 −1
- typo3/sysext/core/Classes/Imaging/ImageProcessingInstructions.php+0 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/Permutation.php+1 −1
Review log 1418
-
Benni Mack uploaded patch set 1 02/27/26, 16:25
-
Benni Mack marked it work in progress 02/27/26, 16:26
-
Benni Mack updated the commit message in patch set 2 02/27/26, 16:28
-
core-ci voted on patch set 2 V +1 02/27/26, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96981
-
core-ci voted on patch set 1 V +1 02/27/26, 17:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96980
-
Benjamin Franzke commented on patch set 2 CR +1 03/03/26, 16:40
Checked with phpstan level max: `treatPhpDocTypesAsCertain: false`: 60810 errors `treatPhpDocTypesAsCertain: true`: 60856 errors Looks good 👍 Also note: Some years ago (last time I tested it was 2023), `treatPhpDocTypesAsCertain: false` caused PHP API to produce false negatives. Example from back than which works today: https://phpstan.org/r/af3e55da-b4d6-48c1-ae07-1a812e7aa41a I would be fine with merging this. -
Benni Mack commented on patch set 2 03/03/26, 17:00
Reply
we can add some comments above the "phpstan.neon" file so we know why we do this? -
Benni Mack commented on patch set 3
CR +1V +103/04/26, 12:53Published edit on patch set 2. -
Benni Mack marked it ready for review 03/04/26, 12:53
-
Benni Mack commented on patch set 3 03/04/26, 12:53
Reply
Done -
core-ci voted on patch set 3 V -1 03/04/26, 13:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97318
-
Benni Mack uploaded patch set 4
V -103/04/26, 13:08 -
core-ci voted on patch set 4 V +1 03/04/26, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97321
-
Garvin Hicking commented on patch set 4 CR +1 V +1 03/04/26, 14:01
gg -
Oliver Klee voted on patch set 4 CR +1 V +1 03/04/26, 15:41
-
Oliver Klee commented on patch set 4 03/04/26, 15:41
Yeah, makes sense. -
Benni Mack voted on patch set 4 CR +2 V +2 03/04/26, 15:52
-
Benni Mack merged patch set 5 03/04/26, 15:52