Review main Merged

93029[TASK] Render recycler module with initial data server-side

Benni Mack CR +2 V +2 Hard +410 −314 updated 03/04/26, 16:20

Commit message

The recycler module previously rendered an empty shell and
required two sequential AJAX round-trips (getTables + getDeletedRecords)
before any content was visible to the user.

With this change, the module loads with the table dropdown
pre-populated, depth selection restored and deleted records
rendered immediately — eliminating the initial loading flicker
and matching the server-side rendering approach used by other
backend modules like beuser, belog and filelist.

Subsequent user interactions (changing depth, table filter,
search, pagination, undo/delete) continue to use AJAX as before.

A new RecyclerService extracts the shared data-fetching logic
so both the module controller and the AJAX controller use the
same code paths without duplication.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 810

  1. Benni Mack uploaded patch set 1 02/27/26, 21:46

  2. core-ci voted on patch set 1 V +1 02/27/26, 21:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96994

  3. Christian Kuhn commented on patch set 1 03/03/26, 14:16

    RecyclerModule.fluid.html:49

    could we move this 'if' around the 'tbody' part only to de-duplicate the caption&head part? i was quite confused at first, until i recognized the head part is just a duplication of what we have a few lines below already.
  4. Benni Mack commented on patch set 1 03/03/26, 14:49

    RecyclerModule.fluid.html:49 Reply

    I do have the <typo3-backend-alert> in the bottom part and a hidden attribute on the div.table-fit. but yes. we can consolidate this.
  5. Christian Kuhn commented on patch set 1 CR +1 V +1 03/03/26, 15:00

    RecyclerModule.fluid.html:49 Reply

    well, looking at this in an IDE isn't that bad and currently quite obvious. i didn't spot the 'hidden' difference, too. i'm also fine with just keeping as is. played around a bit, lgtm.
  6. Benni Mack uploaded patch set 2 CR +1 V +1 03/04/26, 13:04

  7. core-ci voted on patch set 2 V +1 03/04/26, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97319

  8. Christian Kuhn voted on patch set 2 CR +1 V +1 03/04/26, 14:03

  9. Georg Ringer voted on patch set 2 CR +2 V +2 03/04/26, 16:20

  10. Georg Ringer merged patch set 3 03/04/26, 16:20