93036[BUGFIX] Use numerical f:translate arguments instead named arguments
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Benjamin Franzke +1
- Benni Mack +1
-
Verified V +2 Done
- Garvin Hicking +2
- Benjamin Franzke +1
- Riccardo De Contardi +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 3
Review log 1013
-
Garvin Hicking uploaded patch set 1 03/02/26, 13:18
-
Garvin Hicking uploaded patch set 2 03/02/26, 13:23
-
core-ci voted on patch set 1 V +1 03/02/26, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97107
-
Garvin Hicking updated the commit message in patch set 3 03/02/26, 13:28
-
Benjamin Franzke commented on patch set 2 03/02/26, 13:28
I guess you ran this throw $IDE. Did it check multiline usages? -
core-ci voted on patch set 2 V +1 03/02/26, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97108
-
core-ci voted on patch set 3 V +1 03/02/26, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97109
-
Garvin Hicking commented on patch set 3 03/02/26, 13:48
Reply
Yes, I used the "m" regexp multiline operator, and manually went through all 102+33 results. Zero AI tokens were involved in the process of checking this. ;) -
Benjamin Franzke commented on patch set 3 CR +1 V +1 03/02/26, 13:54
Reply
Haven't found more via: ``` find typo3 -name '*.fluid.html' | while read file; do sed -e :a -e '/$/N; s/\n/ /; ta' $file | grep "<f:translate[^>]*arguments=\"{[ \\t\\n]*[^ \\t\\n0-9]"; done ``` and ``` find typo3 -name '*.fluid.html' | while read file; do sed -e :a -e '/$/N; s/\n/ /; ta' $file | grep "{f:translate([^}]*arguments:[ ]*'{[ \\t\\n]*[^ \\t\\n0-9]"; done ``` -
Riccardo De Contardi commented on patch set 3 V +1 03/02/26, 14:01
verified on media module -
Benni Mack voted on patch set 3 CR +1 V +1 03/02/26, 14:08
-
Garvin Hicking voted on patch set 3 CR +2 V +2 03/02/26, 15:20
-
Garvin Hicking merged patch set 4 03/02/26, 15:20