Review main Merged

93039[FEATURE] Context-aware editing in page module

Oli Bartsch CR +2 V +2 Expert +2405 −54 updated 04/20/26, 09:23

Commit message

Introduce a new typo3-backend-context-panel web
component that renders a slide-in panel on top of
the current view. The panel supports iframe, ajax,
and inline content modes. It can be placed on any
side (start, end, top, bottom) via the placement
option and comes in three sizes (small, medium,
large).

A new ContextualRecordEditController provides a
dedicated single-record editing route with a
streamlined FormEngine UI for use inside the
context panel.

The page module now uses the context panel for
editing page properties and content elements.
Edit buttons render a `typo3-backend-contextual-record-edit-trigger`
component that opens the panel while keeping
the page layout visible. The user setting
`contextualRecordEdit` (enabled by default)
controls whether the context panel or the
traditional full-page form is used.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Matthias Vogel +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Matthias Vogel +1
    • core-ci +1 CI

Issues 1

Files 37

Show 17 more files

Review log 3850

Show 1725 earlier messages
  1. Oli Bartsch uploaded patch set 1 03/02/26, 22:24

  2. Oli Bartsch marked it work in progress 03/02/26, 22:25

  3. Oli Bartsch uploaded patch set 2 03/02/26, 22:28

  4. core-ci voted on patch set 1 V -1 03/02/26, 22:36 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 2 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97138

  5. core-ci voted on patch set 2 V -1 03/02/26, 22:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97139

  6. Mathias Brodala commented on patch set 2 03/03/26, 07:42

    standalone-record-edit.ts:37

    From reading this should be "Embedded" or similar instead. Contrary to the suggested name this is not standalone; the old/current editing view would be standalone as it can "stand alone" without having/requiring a context.
  7. Oli Bartsch uploaded patch set 3 V -1 03/03/26, 11:01

  8. Oli Bartsch commented on patch set 3 03/03/26, 11:01

    standalone-record-edit.ts:37 Reply

    Done
  9. core-ci voted on patch set 3 V -1 03/03/26, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97167

  10. Oli Bartsch uploaded patch set 4 V -1 03/03/26, 22:35

  11. core-ci voted on patch set 4 V -1 03/03/26, 22:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97232

  12. Oli Bartsch uploaded patch set 5 V -1 03/03/26, 23:31

  13. core-ci voted on patch set 5 V +1 03/03/26, 23:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97236

  14. Oli Bartsch commented on patch set 5 03/03/26, 23:43

    This change is ready for review.
  15. Oli Bartsch uploaded patch set 6 V +1 03/03/26, 23:57

  16. core-ci voted on patch set 6 V +1 03/04/26, 00:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97238

  17. Benni Mack commented on patch set 7 V +1 03/04/26, 08:22

    Published edit on patch set 6.
  18. core-ci voted on patch set 7 V +1 03/04/26, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97269

  19. Riccardo De Contardi commented on patch set 7 V -1 03/04/26, 09:09

    [BUG] when you click on "open full editing view" the box shadow (violet??) still remains visible on the right side, refresh browser to remove it.
  20. Riccardo De Contardi commented on patch set 7 03/04/26, 09:24

    minor complains [UI] the panel box-shadow is really thick and violet (?). Does not match anything in the styleguide AFAICS. Are you sure you want to keep it like that? [UI] the title of the panel (like "Edit Page "..."") is really near the edge and overlaps too much with the huge rounded corner, please consider to use a left padding at least equal to the rounded corner - in case, make the the panel larger [UX] it took me a bit to understand what the "Open full editing view" does, because the panel went out on the right, and I was not immediately aware that the page below changed. I don't have a solution for that; I think that we could experiment with an animation that goes on the opposite side + fade so it could give the illusion that the panel actually _expands_ itself instead of being pushed away. Maybe. Just a wild suggestion. [UX] please consider disabling the feature below 992px of viewport width (tablet mode)
  21. Oli Bartsch uploaded patch set 8 V +1 03/04/26, 09:49

  22. Oli Bartsch uploaded patch set 9 03/04/26, 09:53

  23. Oli Bartsch uploaded patch set 10 03/04/26, 09:55

  24. Matthias Vogel voted on patch set 10 CR +1 V +1 03/04/26, 09:59

  25. core-ci voted on patch set 10 V +1 03/04/26, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97296

  1. core-ci voted on patch set 8 V +1 03/04/26, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97290

  2. core-ci voted on patch set 9 V -1 03/04/26, 10:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97293

  3. Oli Bartsch uploaded patch set 11 CR +1 V +1 03/04/26, 10:35

  4. Oli Bartsch commented on patch set 11 03/04/26, 10:40

    Reply

    * I have removed the prominent violet shadow again and streamlined with modal shadow. * I have added additional padding for the title on desktop * Not sure about this. I actually never had the problem of not recognizing the change. I would suggest to keep for now and reevaluate if more people have this feeling. * It is intended to have this feature on mobile as well. I actually optimized the component for use on mobile. Do you have any problems working with it on mobile?

    Reply

    Thanks, fixed.
  5. core-ci voted on patch set 11 V +1 03/04/26, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97298

  6. Matthias Vogel voted on patch set 11 CR +1 V +1 03/04/26, 10:50

  7. Riccardo De Contardi commented on patch set 11 V +1 03/04/26, 10:53

    Reply

    Thank you Oli for this great piece of work! 1. Thank you, I think it's much more professional like that 2. Can't see any difference right now :/ 3. I understand! That requires testing with actual users 4. Seen it - same as the previous one. Real test is necessary. IMHO in the mobile context you can simplify the interface, it looks (to me at least) an additional click that can be skipped. Eager to discuss this on Slack BTW: new tabs appearance is gorgeous! I hope it will be adopted in all the TYPO3 backend!
  8. Georg Ringer voted on patch set 11 CR +1 V +1 03/04/26, 12:26

  9. Oli Bartsch uploaded patch set 12 CR +1 V +1 03/04/26, 12:33

  10. Matthias Vogel voted on patch set 12 CR +1 V +1 03/04/26, 12:37

  11. Georg Ringer voted on patch set 12 CR +1 V +1 03/04/26, 12:39

  12. core-ci voted on patch set 12 V +1 03/04/26, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97317

  13. Oli Bartsch voted on patch set 12 CR +2 V +2 03/04/26, 12:44

  14. Oli Bartsch merged patch set 13 03/04/26, 12:44

  15. Benjamin Franzke commented on patch set 13 03/04/26, 14:36

    Can you explain why multiple `<typo3-backend-context-panel>` elements are being rendered? I'd also be interested in why you chose not to use existing TYPO3 backned modal infrastructure (in can be aligned to sides), or at least `<dialog>` (for builtin a11y)? (Fixed positioning for dialogs is no longer state of the art)
  16. Oli Bartsch commented on patch set 13 03/04/26, 18:15

    Reply

    I did not use the modal, because it is not a modal. It behaves differently. We needed a new component independent of the modal functionality. Using `<dialog>` is a valid concern. I therefore migrated the component, see https://review.typo3.org/c/Packages/TYPO3.CMS/+/93070. This patch also includes proper clean up of `<typo3-backend-context-panel>` elements.
  17. Benjamin Franzke commented on patch set 13 03/04/26, 20:09

    Reply

    It is a modal. https://en.wikipedia.org/wiki/Modal_window > A modal window creates a mode that disables user interaction with the main window but keeps it visible, with the modal window as a child window in front of it.
  18. Benjamin Kott commented on patch set 13 03/04/26, 22:44

    post -1 this patch has several problems 1. tab styling differenciates from existing tabs, these new stylings are not documented in styleguide wrapping them into the new component is a hit in the face for everyone that tries to cleanup this mess called css for the last years, nor do we have the overflow behavior in other places 2. i have little to no word for the css merged here, this is now how we write css, we write components and use little to no overwrites, styles introcuded need to be documented in styleguide 3. the new component duplicates functionality that already exists in the modal api, and i agree with benjamin here, this should have been used. there is no difference aside from this is worse in a11y 4. the success message in the top bar of the "modal" is something we never had before, and is also no documented styling pattern we use here, it leads to jumping of the title especially in smaller screens 5. the positioning on smaller screens is offsetted and not working as expected it changes behavior and now slides up from the bottom 6. the radii used for the top corners look wiered and are way to big in contrast to the backend in general also the scrollbars are cut off on windows and linux systems 7. the refresh of the components is completly missing, i can see the records i am opening and they are not updated accordingly when the data is saved, its relying on a reload on close 8. the was not tested in darkmode, the active tab entries are not readable, badges are broken and show different colors than in the normal mode 9. the spacings for the save zones to the left and right are too small
  19. Benjamin Kott commented on patch set 13 03/04/26, 22:45

    Reply

    this was just a quick first look, will follow up with a more detailed review
  20. Benjamin Kott commented on patch set 13 03/04/26, 22:56

    Reply

    fully agree here, it was already discussed in advance, and the modal was prepared with additional positions so it can handle it.
  21. Oli Bartsch commented on patch set 13 03/05/26, 09:08

    Reply

    I tried using the modal, but it did not work out well. In general, it does not seem reasonable to turn the modal into a one-size-fits-all solution. We might actually consider reducing some of the options it currently offers to keep it closer to its intended purpose. In the UI guidelines I looked up, modals are documented as dialogs placed centered on the screen, while offcanvas elements slide in from the side. These are different behaviors serving different use cases. I also did not want to inherit all the options the modal currently offers, and customizing it for specific offcanvas needs would have added unnecessary complexity on top of an implementation that wasn't designed for this pattern.

    Reply Unresolved

    Thanks for the feedback. I will try to answer all of the mentioned points: 1. The tab styling was taken directly from the mockups we discussed and agreed on. Since this is a first iteration, in contrast to the component itself, it has not been added to the styleguide yet. 2. Who exactly is "we" here? I'm honest, I would really like to make it "right". Appreciate a pointer to a CSS styleguide that the core team has agreed on. I'm hapy to follow that. 3. Already addressed in the other comment 4. Similar to the button patterns, this is an intentional first try. Notifications are hidden behind the component, so we need a new way to communicate a successful save. This was the initial approach. Open to refining it. 5. This is intentional. The goal is to use maximum screen width while keeping 80% height to preserve the overlay "feeling". Happy to discuss if the behavior doesn't feel right, but it's not a bug. 6. The radii were chosen based on the layout. If they don't align precisely with the rest of the backend, that's an easy adjustment. No problem there. 7. This is intentional, not a bug. In an earlier iteration I sent refresh events on every save, which turned out to be really disruptive. The page tree and content frame kept refreshing in the backdrop all the time. The current approach visualy applies changes after editing is finished. Worth discussing, but please don't file this as a defect. 8. Agreed, dark mode needs work. Will be addressed. 9. What specifically is too small? Is there a defined spacing guide or reference I can look at? Without a concrete benchmark it's hard to action this.
  22. Benjamin Franzke commented on patch set 13 03/05/26, 18:53

    Reply

    > because it is not a modal. Your followup patch, which copies quite some code from `modal.ts` into the `context-panel.ts`, now even used `dialog.showModal()`: https://review.typo3.org/c/Packages/TYPO3.CMS/+/93070/1/Build/Sources/TypeScript/backend/element/context-panel.ts#140 Are you sure it is not a modal?
  23. Oli Bartsch commented on patch set 13 03/05/26, 19:27

    Reply Unresolved

    I was not involved in writing the browser API spec. Perhaps `showDialog()` would have been a better name. To be clear, I am not referring to the general concept of a modal, but to our own TYPO3 Modal component with all its specific implementation details and use cases. The context panel may well qualify as a "modal" by some UI guideline definitions, but it is not the same as the Modal component we have in TYPO3. It has different behavior, different functionality, and serves a different purpose.
  24. Lina Wolf commented on patch set 13 04/19/26, 13:10

    There is no page module anymore, it is called Content > Layout now, The option should be called "Use quick editing for records in the "Layout" module"
  25. Garvin Hicking commented on patch set 13 04/20/26, 09:23

    Reply

    @112@linawolf.de Thanks - the XLF file was already changed a few days ago actually.