Review main Merged

93041[TASK] Move site set enum labels to labels.xlf

Eric Harrer CR +2 V +2 Normal +156 −19 updated 03/04/26, 07:14

Commit message

Move enum labels from TYPO3 Core site set
settings.definitions.yaml files to labels.xlf and use
list-style enum declarations.

Add functional fixture coverage for list-style enum parsing.
Adjust set label integrity check for enum label identifiers.
Cover list-style enums and explicit {label}:... references.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Sebastian Iffland +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 912

  1. Eric Harrer uploaded patch set 1 03/03/26, 14:15

  2. Eric Harrer updated the commit message in patch set 2 03/03/26, 14:24

  3. core-ci voted on patch set 1 V -1 03/03/26, 14:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97188

  4. core-ci voted on patch set 2 V -1 03/03/26, 14:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97189

  5. Benni Mack commented on patch set 2 03/03/26, 14:38

    hey, can you elaborate why this needs to be done? Why this is better than the existing solution?
  6. Eric Harrer uploaded patch set 3 V -1 03/03/26, 15:07

  7. Eric Harrer commented on patch set 2 03/03/26, 15:14

    Reply

    All label and description values were already moved out of settings.definitions.yaml to labels.xlf identifiers. Enum option labels were the last remaining inline labels. Moving them to labels.xlf completes that migration and makes those labels properly translatable like the rest.
  8. core-ci voted on patch set 3 V +1 03/03/26, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97192

  9. Garvin Hicking commented on patch set 3 CR +1 V +1 03/03/26, 21:28

    tbh I'm not 100% sure on the checkIntegrityScript... but it seems to do the trick?!
  10. Sebastian Iffland voted on patch set 3 CR +1 03/04/26, 07:11

  11. Benjamin Franzke commented on patch set 3 CR +2 V +2 03/04/26, 07:14

    Reply

    ack 👍
    thanks!
  12. Benjamin Franzke merged patch set 4 03/04/26, 07:14