93041[TASK] Move site set enum labels to labels.xlf
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- Sebastian Iffland +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 12
- Build/Scripts/checkIntegritySetLabels.php+51 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/SetEnumLabels/labels.xlf+12 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/SetEnumLabels/settings.definitions.yaml+6 −0
- typo3/sysext/core/Tests/Functional/Site/Set/YamlSetDefinitionProviderTest.php+15 −0
- typo3/sysext/felogin/Configuration/Sets/Felogin/labels.xlf+18 −0
- typo3/sysext/felogin/Configuration/Sets/Felogin/settings.definitions.yaml+6 −6
- typo3/sysext/fluid_styled_content/Configuration/Sets/FluidStyledContent/labels.xlf+18 −0
- typo3/sysext/fluid_styled_content/Configuration/Sets/FluidStyledContent/settings.definitions.yaml+6 −6
- typo3/sysext/indexed_search/Configuration/Sets/IndexedSearch/labels.xlf+6 −0
- typo3/sysext/indexed_search/Configuration/Sets/IndexedSearch/settings.definitions.yaml+2 −2
- typo3/sysext/theme_camino/Configuration/Sets/camino/labels.xlf+12 −0
- typo3/sysext/theme_camino/Configuration/Sets/camino/settings.definitions.yaml+4 −4
Review log 912
-
Eric Harrer uploaded patch set 1 03/03/26, 14:15
-
Eric Harrer updated the commit message in patch set 2 03/03/26, 14:24
-
core-ci voted on patch set 1 V -1 03/03/26, 14:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97188
-
core-ci voted on patch set 2 V -1 03/03/26, 14:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97189
-
Benni Mack commented on patch set 2 03/03/26, 14:38
hey, can you elaborate why this needs to be done? Why this is better than the existing solution? -
Eric Harrer uploaded patch set 3
V -103/03/26, 15:07 -
Eric Harrer commented on patch set 2 03/03/26, 15:14
Reply
All label and description values were already moved out of settings.definitions.yaml to labels.xlf identifiers. Enum option labels were the last remaining inline labels. Moving them to labels.xlf completes that migration and makes those labels properly translatable like the rest. -
core-ci voted on patch set 3 V +1 03/03/26, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97192
-
Garvin Hicking commented on patch set 3 CR +1 V +1 03/03/26, 21:28
tbh I'm not 100% sure on the checkIntegrityScript... but it seems to do the trick?! -
Sebastian Iffland voted on patch set 3 CR +1 03/04/26, 07:11
-
Benjamin Franzke merged patch set 4 03/04/26, 07:14