Review main Merged

93044[TASK] Improve exception messages for missing Fluid templates

Simon Praetorius CR +2 V +2 Normal +156 −28 updated 03/13/26, 11:50

Commit message

This patch aims to ease debugging in cases where Fluid templates are
referenced somewhere, but the file cannot be found in the supported
locations. Fluid 5.2 introduced dedicated exceptions for missing
partials and layouts and added error information to the underlying
exception, which can now be used within TYPO3 to create more meaningful
exception messages.

* The `PAGEVIEW` TypoScript content object already had a custom
  exception message. The adjusted message now includes the full list
  of template candidates that have been checked.
* The `FLUIDTEMPLATE` TypoScript content object now follows `PAGEVIEW`
  and adds its own custom exception message.
* The exception for missing component templates is adjusted accordingly.

This means that users can now differentiate if a missing template is:

* a partial
* a layout
* a template from `PAGEVIEW`
* a template from `FLUIDTEMPLATE`
* a template for a Fluid component

and get the full list of possible locations where the file can be placed.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Christian Kuhn +1
    • Matthias Vogel +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Christian Kuhn +1
    • Matthias Vogel +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1829

Show 24 earlier messages
  1. Simon Praetorius uploaded patch set 1 03/03/26, 17:19

  2. core-ci voted on patch set 1 V -1 03/03/26, 17:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97204

  3. Simon Praetorius uploaded patch set 2 V -1 03/03/26, 18:17

  4. core-ci voted on patch set 2 V -1 03/03/26, 18:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97209

  1. Simon Praetorius uploaded patch set 3 V -1 03/03/26, 20:08

  2. core-ci voted on patch set 3 V -1 03/03/26, 20:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97221

  3. Simon Praetorius uploaded patch set 4 V -1 03/03/26, 21:30

  4. core-ci voted on patch set 4 V -1 03/03/26, 21:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97228

  5. Simon Praetorius uploaded patch set 5 V -1 03/03/26, 21:39

  6. core-ci voted on patch set 5 V -1 03/03/26, 21:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97229

  7. Simon Praetorius uploaded patch set 6 V -1 03/03/26, 23:46

  8. core-ci voted on patch set 6 V -1 03/03/26, 23:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97237

  9. Matthias Vogel voted on patch set 6 CR +1 03/04/26, 08:58

  10. Simon Praetorius uploaded patch set 7 CR +1 V -1 03/04/26, 18:48

  11. core-ci voted on patch set 7 V -1 03/04/26, 19:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97354

  12. Simon Praetorius uploaded patch set 8 V -1 03/05/26, 09:21

  13. core-ci voted on patch set 8 V -1 03/05/26, 10:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97395

  14. Simon Praetorius uploaded patch set 9 V -1 03/11/26, 12:46

  15. core-ci voted on patch set 9 V +1 03/11/26, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97759

  16. Simon Praetorius uploaded patch set 10 V +1 03/13/26, 10:46

  17. Simon Praetorius marked it ready for review 03/13/26, 10:47

  18. Matthias Vogel voted on patch set 10 CR +1 V +1 03/13/26, 10:56

  19. core-ci voted on patch set 10 V -1 03/13/26, 11:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97881

  20. Christian Kuhn uploaded patch set 11 CR +1 V +1 03/13/26, 11:22

  21. Matthias Vogel voted on patch set 11 CR +1 V +1 03/13/26, 11:23

  22. Christian Kuhn voted on patch set 11 CR +1 V +1 03/13/26, 11:25

  23. core-ci voted on patch set 11 V +1 03/13/26, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97885

  24. Simon Praetorius voted on patch set 11 CR +2 V +2 03/13/26, 11:50

  25. Simon Praetorius merged patch set 12 03/13/26, 11:50