Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
93046[FEATURE] Introduce InspectorEditorRegistry for ext:form
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 6
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/46/93046/6 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/46/93046/6 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 1
Files 44
- typo3/sysext/core/Documentation/Changelog/14.2/Deprecation-109143-FormEditorPartialsForInspectorEditors.rstnew+115 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-109143-InspectorEditorRegistryForFormFramework.rstnew+212 −0
- typo3/sysext/form/Classes/Attribute/AsFormInspectorEditor.phpnew+42 −0
- typo3/sysext/form/Classes/Controller/FormEditorController.php+93 −3
- typo3/sysext/form/Classes/DependencyInjection/InspectorEditorPass.phpnew+59 −0
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/FormElement/MultiValuePropertiesExtractor.php+23 −44
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/FormElement/PropertyPathsExtractor.php+22 −21
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/FormElement/SelectOptionsExtractor.php+39 −32
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/PropertyCollectionElement/IsCreatablePropertyCollectionElementExtractor.php+22 −25
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/PropertyCollectionElement/MultiValuePropertiesExtractor.php+49 −41
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/ExtractorDto.php+15 −0
- typo3/sysext/form/Classes/Domain/Configuration/ConfigurationService.php+3 −0
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinitionConversionService.php+9 −3
- typo3/sysext/form/Classes/Domain/FormEditor/InspectorEditor/AbstractInspectorEditor.phpnew+73 −0
- typo3/sysext/form/Classes/Domain/FormEditor/InspectorEditor/CheckboxEditor.phpnew+29 −0
- typo3/sysext/form/Classes/Domain/FormEditor/InspectorEditor/CollectionElementHeaderEditor.phpnew+29 −0
- typo3/sysext/form/Classes/Domain/FormEditor/InspectorEditor/CountrySelectEditor.phpnew+29 −0
- typo3/sysext/form/Classes/Domain/FormEditor/InspectorEditor/FinishersEditor.phpnew+43 −0
- typo3/sysext/form/Classes/Domain/FormEditor/InspectorEditor/FormElementHeaderEditor.phpnew+29 −0
- typo3/sysext/form/Classes/Domain/FormEditor/InspectorEditor/GridColumnViewPortConfigurationEditor.phpnew+57 −0
Show 24 more files
- typo3/sysext/form/Classes/Domain/FormEditor/InspectorEditor/InspectorEditorInterface.phpnew+123 −0
- typo3/sysext/form/Classes/Domain/FormEditor/InspectorEditor/InspectorEditorRegistry.phpnew+94 −0
- typo3/sysext/form/Classes/Domain/FormEditor/InspectorEditor/MaximumFileSizeEditor.phpnew+29 −0
- typo3/sysext/form/Classes/Domain/FormEditor/InspectorEditor/MultiSelectEditor.phpnew+34 −0
- typo3/sysext/form/Classes/Domain/FormEditor/InspectorEditor/PropertyGridEditor.phpnew+50 −0
- typo3/sysext/form/Classes/Domain/FormEditor/InspectorEditor/RemoveElementEditor.phpnew+29 −0
- typo3/sysext/form/Classes/Domain/FormEditor/InspectorEditor/RequiredValidatorEditor.phpnew+55 −0
- typo3/sysext/form/Classes/Domain/FormEditor/InspectorEditor/SingleSelectEditor.phpnew+29 −0
- typo3/sysext/form/Classes/Domain/FormEditor/InspectorEditor/TextareaEditor.phpnew+37 −0
- typo3/sysext/form/Classes/Domain/FormEditor/InspectorEditor/TextEditor.phpnew+29 −0
- typo3/sysext/form/Classes/Domain/FormEditor/InspectorEditor/Typo3WinBrowserEditor.phpnew+29 −0
- typo3/sysext/form/Classes/Domain/FormEditor/InspectorEditor/ValidationErrorMessageEditor.phpnew+29 −0
- typo3/sysext/form/Classes/Domain/FormEditor/InspectorEditor/ValidatorsEditor.phpnew+43 −0
- typo3/sysext/form/Classes/Service/FormEditorEnrichmentService.php+10 −4
- typo3/sysext/form/Configuration/Yaml/FormSetup.yaml+0 −17
- typo3/sysext/form/Configuration/Services.php+13 −0
- typo3/sysext/form/Tests/Functional/Controller/FormEditorControllerTest.php+4 −0
- typo3/sysext/form/Tests/Functional/Domain/Configuration/ConfigurationServiceTest.php+20 −0
- typo3/sysext/form/Tests/Functional/Domain/Factory/ArrayFormFactoryTest.php+2 −0
- typo3/sysext/form/Tests/Functional/Domain/Model/Renderable/AbstractRenderableTest.php+2 −0
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinitionConversionServiceTest.php+11 −2
- typo3/sysext/form/Tests/Unit/Domain/FormEditor/InspectorEditor/InspectorEditorRegistryTest.phpnew+83 −0
- typo3/sysext/form/Tests/Unit/Domain/FormEditor/InspectorEditor/InspectorEditorTest.phpnew+199 −0
- typo3/sysext/form/Tests/Unit/Service/FormEditorEnrichmentServiceTest.php+17 −8
Review log 1218
-
Josua Vogel uploaded patch set 1 03/03/26, 19:12
-
core-ci voted on patch set 1 V -1 03/03/26, 19:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97215
-
Josua Vogel uploaded patch set 2
V -103/03/26, 19:26 -
core-ci voted on patch set 2 V -1 03/03/26, 19:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97216
-
Josua Vogel rebased onto patch set 3
V -103/03/26, 20:45 -
core-ci voted on patch set 3 V +1 03/03/26, 21:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97223
-
Josua Vogel updated the commit message in patch set 4
V +103/04/26, 06:23 -
core-ci voted on patch set 4 V +1 03/04/26, 06:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97252
-
Josua Vogel commented on patch set 5
V +103/04/26, 16:26Published edit on patch set 4. -
Josua Vogel commented on patch set 6 03/04/26, 16:28
Published edit on patch set 5. -
core-ci voted on patch set 5 V +1 03/04/26, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97344
-
core-ci voted on patch set 6 V +1 03/04/26, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97345
-
Garvin Hicking commented on patch set 6 03/14/26, 20:59
I would really enjoy having this registration in place because it holds a lot of opportunities. But on the other hand I find it quite nice to only have a single YAML file that I could copy around, without needing to pay attention that there might be a matching PHP class lieing around that takes care of the rendering definition then. So my question is: Should we really deprecate and remove the partialName YAML feature, or intentionally support this longer? (honest, open question) -
Josua Vogel commented on patch set 6 03/18/26, 10:09
Reply
I've been thinking about this. A developer creating a custom inspector will have several tasks to complete — the partialName alone isn't enough. You also have to create a Fluid template and write JavaScript code. Sure, the overall process could be improved in the long run, but the lack of an option to set the partialName in YAML isn't really a major limitation. -
Garvin Hicking commented on patch set 6 03/18/26, 10:42
Reply
Yeah but then you'll add PHP to the mix of things you need to address. Especially now that you've made it easier to not necessarily need JavaScript for a definition. And fluid partials could be re-used, so you might not necessarily need to create new partials for new inspectors, if your partial is flexible enough...? -
Josua Vogel commented on patch set 6 03/18/26, 10:52
Reply
I think you mix things up :) I made it easier for custom form elements, but not for the inspectors (the interface elements to edit select options,...). -
Garvin Hicking commented on patch set 6 03/18/26, 11:03
Reply
Hah, you are right. See, that's why you are the form master and I'm your padawan. I'll consider this one resolved, I understand your intent. However, I can't really judge it. -
Josua Vogel marked it work in progress 03/18/26, 14:38