93051[BUGFIX] Handle non-string keys in implodeAttributes
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Oliver Klee +1
- Simon Praetorius +1
-
Verified V +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Oliver Klee +1
- Simon Praetorius +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1213
-
Eric Harrer uploaded patch set 1 03/03/26, 22:47
-
core-ci voted on patch set 1 V +1 03/03/26, 22:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97233
-
Garvin Hicking commented on patch set 1 03/04/26, 05:53
Hm. HTML specs say that a "only numbers" attribute is not allowed. So I wonder if its actually ok to throw an error on these attributes. Wdyt? -
Georg Ringer commented on patch set 1 03/04/26, 06:17
thinkinkg about data attributes, numbers are fine there -
Georg Ringer voted on patch set 1 CR +1 V +1 03/04/26, 06:17
-
Garvin Hicking commented on patch set 1 03/04/26, 06:50
Reply
Its about attributes. "Data-123" is nkt affe ted by the bug. An attribute 123="456" is invalid. -
Simon Praetorius voted on patch set 1 CR +1 V +1 03/04/26, 07:23
-
Georg Ringer commented on patch set 1 03/04/26, 07:56
sry garvin, true -
Oliver Klee voted on patch set 1 CR +1 V +1 03/04/26, 08:07
-
Simon Praetorius commented on patch set 1 03/04/26, 08:13
imho: I don‘t think an exception makes sense in such a low-level function. It the input generates invalid markup, this needs to be dealt with on a higher level -
Christian Kuhn commented on patch set 1 CR +1 V +1 03/04/26, 08:56
agreed: this cast makes sense for this low level method. -
Christian Kuhn voted on patch set 1 CR +2 V +2 03/04/26, 08:57
-
Christian Kuhn merged patch set 2 03/04/26, 09:11