Review main Merged

93053[TASK] Move linkvalidator module to "Link Management" module

Benni Mack CR +2 V +2 Easy +45 −5 updated 03/05/26, 22:33

Commit message

The "Link validator" submodule is moved from "Status" to
"Link Management". Additionally, the module identifier is
changed from `web_linkvalidator` to `linkvalidator_checklinks`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1013

  1. Benni Mack uploaded patch set 1 03/04/26, 07:27

  2. core-ci voted on patch set 1 V +1 03/04/26, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97259

  3. Georg Ringer commented on patch set 1 03/04/26, 07:53

    UserPermissionsForRenamedModulesMigration.php:53

    without testing but shouldn't that be also be part of $moduleRenaming above?
  4. Oli Bartsch commented on patch set 1 03/04/26, 08:20

    UserPermissionsForRenamedModulesMigration.php:53 Reply

    Basically it's not correct. The module has not been renamed. But, without adding it in `$moduleRenaming` it would never be respected.
  5. Benni Mack uploaded patch set 2 V +1 03/05/26, 18:48

  6. core-ci voted on patch set 2 V +1 03/05/26, 18:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97431

  7. Simon Schaufelberger commented on patch set 2 CR +1 V +1 03/05/26, 20:23

    UserPermissionsForRenamedModulesMigration.php:53 Reply

    Done
  8. Oli Bartsch uploaded patch set 3 CR +1 V +1 03/05/26, 21:24

  9. core-ci voted on patch set 3 V +1 03/05/26, 21:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97442

  10. Oli Bartsch voted on patch set 3 CR +1 V +1 03/05/26, 21:42

  11. Josua Vogel voted on patch set 3 CR +1 V +1 03/05/26, 21:45

  12. Oli Bartsch voted on patch set 3 CR +2 V +2 03/05/26, 22:33

  13. Oli Bartsch merged patch set 4 03/05/26, 22:33