Review 13.4 Merged

93062[BUGFIX] Allow persistence to non-uid tables in SaveToDatabaseFinisher

Garvin Hicking CR +2 V +2 Normal +94 −1 updated 03/04/26, 13:56

Commit message

The SaveToDdbFinisher allows persistence to tables that have no
UID column (like "sys_category_record_mm". In this case, a call
to "lastInsertId()" throws an exception (on mysql connections for
example).

With this patch, that exception is caught gracefully. A test
is added to verify this behavior no longer throws an exception.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Garvin Hicking commented on patch set 1 03/04/26, 13:04

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 03/04/26, 13:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97320

  3. Garvin Hicking uploaded patch set 2 V -1 03/04/26, 13:44

    adjust backport
  4. core-ci voted on patch set 2 V +1 03/04/26, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97326

  5. Garvin Hicking voted on patch set 2 CR +2 V +2 03/04/26, 13:56

  6. Garvin Hicking merged patch set 3 03/04/26, 13:56